Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce default callback URI for Socialite #2180

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Introduce default callback URI for Socialite #2180

merged 1 commit into from
Apr 30, 2024

Conversation

josephsnyder
Copy link
Member

Remove the ability to configure the callback URI for the Socialite providers that CDash uses for Oauth. Each URL will be formatted to follow the following string:

<CDash URL>/auth/<provider>/callback

Fixes #2150

@josephsnyder
Introduce default callback URI for Socialite
f7fbe44 
Remove the ability to configure the callback URI for the Socialite
providers that CDash uses for Oauth.  Each URL will be formatted to
follow the following string:

    <CDash URL>/auth/<provider>/callback
williamjallen
williamjallen approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@williamjallen williamjallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, assuming tests pass.

@williamjallen
Copy link
Collaborator

Do you want to change the base branch to releases/3.4? This PR also needs a milestone assigned.

@josephsnyder josephsnyder changed the base branch from master to releases/3.4 April 29, 2024 20:01
@josephsnyder josephsnyder added this to the v3.4 milestone Apr 29, 2024
@williamjallen williamjallen added this pull request to the merge queue Apr 30, 2024
Merged via the queue into releases/3.4 with commit abc2a85 Apr 30, 2024
6 checks passed
@williamjallen williamjallen deleted the socialite_add_default_callback_URI branch April 30, 2024 18:48
@williamjallen williamjallen mentioned this pull request Apr 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamjallen williamjallen williamjallen approved these changes

Assignees
No one assigned
Labels
release notes: fixes
Projects
None yet
Milestone
v3.4
Development

Successfully merging this pull request may close these issues.

Socialite: Bake callback URL defaults into the configuration values for each option
2 participants
@josephsnyder @williamjallen