Move test name column to build2test table
#2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clicked around the site in order to test the functionality, and couldn't find anything broken. 👍 |
williamjallen
commented
May 8, 2024
zackgalbreath
approved these changes
May 8, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 9, 2024
#1455 mistakenly used the test ID instead of the test output ID to find labels for the queryTests page. This issue was separately resolved in the 3.5 release series by the refactor in #2148. Failures like this are a good motivation for our effort to move to a GraphQL API. With GraphQL, there is a single source of truth about where labels come from, and there isn't a need to separately query the labels in dozens of different locations. These types of failures are also a good motivation for more complete testing data, with most tables having at least thousands of rows. With limited data, this failure went unnoticed because each test ID corresponds to a test output ID in the testing environment. This limited issue was resolved by the removal of the test table in #2148.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
#2148 introduced a large migration which has proven to be problematic for CDash instances with many tests. This PR breaks the single large update statement into a batched update process where updates are performed in groups of 5000 rows at a time. Co-authored-by: Zack Galbreath <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The database schema currently has a
build2testtable which contains one row for each instance of a test run, in addition to atesttable which contains deduplicated test names. The joins required when searching forbuild2testrows by test name, or for other relations by test name through thebuild2testrelation, incur a significant amount of indexing overhead, and lead to poor query plans in some cases. The presence of a project ID column on the test relation also encourages poor query design, by applying the project filter to the test relation instead of the build relation.This PR moves the test name to the
build2testtable, and drops thetesttable. This change is almost entirely internal, but has the potential to boost query performance in several places, as well as simplify future additions to the GraphQL API. The database migration associated with this change is large and may take a significant amount of time to apply on large CDash systems.