Drop unused build log column #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zackgalbreath Do you feel comfortable including this in 3.4, or should we push this to 3.5? |
|
For reference, here's a link to the relevant code in CTest: Unless I'm overlooking something, I don't think there's currently any way for Build.xml's |
josephsnyder
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log column in the build table appears to be unused. Information can be written to the column, but there is no way to extract the contents. Since this appears to be a legacy feature which is obsolete in CDash today, I have removed the log column and all remaining references to it. Build.xml files containing the LOG element will be ignored.
While I've done a significant amount of digging to try to find additional references to the log column, it is theoretically possible that the column is still referenced in a SQL query or via reflection somewhere.