Don't fail date validation on PHP >= 8.2 #2030
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified here, before PHP 8.2.0,
DateTime::getLastErrors()
did not returnfalse
when there were no warnings or errors. Instead, it would always return the documented array structure. But on PHP 8.2.0 and newer, it actually may befalse
, and usingarray_sum()
on it shall cause an error like:And this leads to complete unusable build results pages except the one for current date.
This PR fixes it.