Add loading indicator Vue template #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
vue-loading-template
branch
from
302b113 to
812655e
Compare
josephsnyder
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently provide no information about the state of the page for pages with API endpoints which take a long time to return. This PR adds a Vue template which accepts a slot for content to be rendered when the page is loaded, and a boolean prop which indicates whether the loading indicator should be shown. I have initially used this template to add loading indicators to two pages as an example for future use. I plan to switch the loading indicator icon to a Font Awesome icon instead of a grainy GIF once #1895 is merged.