Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate the SubProject Dependencies page to Vue #1882

Merged
merged 7 commits into from
Jan 2, 2024
Merged

Migrate the SubProject Dependencies page to Vue #1882

merged 7 commits into from
Jan 2, 2024

Conversation

sbelsk
Copy link
Collaborator

@sbelsk sbelsk commented Dec 13, 2023 •
edited
Loading

This PR continues our ongoing effort to migrate from AngularJS to Vue.

@sbelsk sbelsk force-pushed the migrate-subproject-dependencies-to-vue branch from 8d2ca03 to 21553e5 Compare December 14, 2023 16:08
@sbelsk
Copy link
Collaborator Author

sbelsk commented Dec 14, 2023

Note: with these changes, the header on this page doesn't display the "settings" and "dashboard" links anymore due to the way resources/views/components/header.blade.php is set up. Changing this is outside of the scope of this PR, but it will be addressed soon in a separate PR.

@sbelsk sbelsk force-pushed the migrate-subproject-dependencies-to-vue branch from e18a90f to 1442559 Compare December 22, 2023 21:32
@sbelsk sbelsk marked this pull request as ready for review December 25, 2023 22:14
williamjallen
williamjallen requested changes Dec 26, 2023
View reviewed changes
@sbelsk sbelsk force-pushed the migrate-subproject-dependencies-to-vue branch from 4474dc3 to 445e816 Compare December 27, 2023 23:37
williamjallen
williamjallen requested changes Dec 29, 2023
View reviewed changes
@sbelsk sbelsk force-pushed the migrate-subproject-dependencies-to-vue branch from 445e816 to 3590cc9 Compare January 2, 2024 15:02
@sbelsk sbelsk force-pushed the migrate-subproject-dependencies-to-vue branch from 3590cc9 to 25e495c Compare January 2, 2024 15:12
@sbelsk sbelsk requested a review from williamjallen January 2, 2024 16:51
williamjallen
williamjallen approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@williamjallen williamjallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It would be good to refactor this page eventually, but we can do that in conjunction with the GraphQL refactor at a future point.

@williamjallen williamjallen added this pull request to the merge queue Jan 2, 2024
Merged via the queue into Kitware:master with commit d044148 Jan 2, 2024
1 check passed
@sbelsk sbelsk deleted the migrate-subproject-dependencies-to-vue branch January 9, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamjallen williamjallen williamjallen approved these changes

Assignees
No one assigned
Labels
release notes: user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbelsk @williamjallen