Update handler: Ignore empty site field #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
update-handler-missing-site
branch
from
2c95adb to
377b3e5
Compare
There was a problem hiding this comment.
@williamjallen, I'm having some trouble testing this one. I've updated the Update2.xml file to have an empty <Site> param:
diff --git a/app/cdash/tests/data/UpdateAppend/Update_2.xml b/app/cdash/tests/data/UpdateAppend/Update_2.xml
index 1fc65cca7..c9ab94811 100644
--- a/app/cdash/tests/data/UpdateAppend/Update_2.xml
+++ b/app/cdash/tests/data/UpdateAppend/Update_2.xml
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Update mode="Client" Generator="ctest-3.3.20150717-ga541" Append="true">
- <Site>Dash20.kitware</Site>
+ <Site></Site>
but the test still fails and an error appears in the CDash log after executing the updateappend test:
[2023-09-28 18:57:02] testing.WARNING: Failed to process EmailProjectExample_-__-_0c23095d-e35d-47e2-a3a7-3efd65d65916_-_.xml with message: Attempt to read property "id" on null
Did you modify a different test locally or do we think that error is somewhere further down the line?
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 29, 2023
PHPStan provides a set of [rule levels](https://phpstan.org/user-guide/rule-levels) which provide increasingly strict code analysis. We currently use level 6. PHPStan level 8 checks nullable types in greater detail, which will prevent a few common types of bugs, including the one fixed in #1725. I was forced to also turn on level 7. Level 7 checks union types, which will significantly improve our error detection abilities, but comes with the caveat that checking for all of the error cases for functions which return false instead of throwing an exception will cause additional developer overhead. Eventually, we should turn on level 9, but it would be pointless to do so without turning on `treatPhpDocTypesAsCertain`. PHPStan cannot currently understand Laravel's type casting system, which means that we'd have to rely upon the PHPDoc types for level 9 to be of any practical use.
williamjallen
force-pushed
the
update-handler-missing-site
branch
from
377b3e5 to
bae6382
Compare
|
@josephsnyder Fixed. I (again) made some edits after testing and forgot that builds must be associated with a site. Eventually, we should probably loosen the non-null constraint and allow builds to have a null site, rather than associating builds with a dummy "unknown" site. |
josephsnyder
approved these changes
Oct 2, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
williamjallen
force-pushed
the
update-handler-missing-site
branch
from
bae6382 to
a7e211f
Compare
zackgalbreath
pushed a commit
that referenced
this pull request
Nov 6, 2023
The update handler currently fails when a submission with a blank `<site>` tag is present. If a blank site tag is included in an update XML file, CDash will now ignore it gracefully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update handler currently fails when a submission with a blank
<site>tag is present.If a blank site tag is included in an update XML file, CDash will now ignore it gracefully.