-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove LOC displays from coverage graph #1576
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an easy way to re-add the loc(un)tested
data to the plot. The code itself looks fine, but I think having the loc data on the plot is valuable information to include.
@williamjallen, @zackgalbreath thought it would be cleaner to have only the one plot and one axis on the page. I was thinking a hover/tooltip like (http://www.flotcharts.org/flot/examples/interacting/) would give us the information we really want without being too confusing. ETA: Demonstration of Tooltip: Is that reasonable? |
@josephsnyder I like that idea. That way, if the coverage drops (or spikes) suddenly you can do a little bit of preliminary exploration to determine the cause. |
5f5a288
to
16d6837
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, one request: Can you add labels to the axes? It's not clear what the x-axis is. I think it also might be good to fix the bounds so it always shows a scale from 0 to 100% on the y-axis. As it is now, it looks like Cmake had a drastic drop, when it really only dropped less than 1%.
@williamjallen, I don't see a way to pin the axis values to a set number. By adding a step to the x axis label, I think we can clarify that it's supposed to be a build time: |
@josephsnyder That seems reasonable to me. Perhaps we should also include the date with those timestamps though... |
To eliminate an error where the Lines Of Code data attempted to access a non-existant yaxis object, remove the plots for LOC from the coverage over time display. Use the information in tooltip instead of additional plots on the single graph.
16d6837
to
de561d5
Compare
To eliminate an error where the Lines Of Code data attempted to access a non-existant yaxis object, remove the plots for LOC from the coverage over time display.
With an update to the design, they may be reintroduced by switching to
yaxes
in the plot'soptions
object and then reintroducing the data.Previous State:
Current State:
