Introduce the concept of parent builds #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the way that subprojects are handled. Before this commit, the number of build errors, test failures, etc. was accumulated across related subproject builds every time index.php was rendered. Now this math is only done once at the time of submission. This simplifies the logic in index.php, allowing it to render more quickly while using less memory. Going forward, it should also allow us to introduce new subproject features, such as viewing all build errors across packages for a particular build.
parentid is enough info to find the builds, date is unnecessary.
Instead of discarding a build from an unrecognized subproject, we now add it to the project automatically.
If a parent build has no actual coverage of its own, CDash should link to its children's coverage instead.
zackgalbreath
added a commit
that referenced
this pull request
Feb 6, 2015
Introduce the concept of parent builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way that subprojects are handled.
Before this commit, the number of build errors, test failures, etc.
was accumulated across related subproject builds every time index.php
was rendered.
Now this math is only done once at the time of submission. This
simplifies the logic in index.php, allowing it to render more quickly
while using less memory. Going forward, it should also allow us to
introduce new subproject features, such as viewing all build errors
across packages for a particular build.