Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 9 additions & 15 deletions src/StructuredLogger/BinaryLogger/BuildEventArgsReader.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1365,18 +1365,18 @@ private BuildEventArgs ReadPropertyReassignmentEventArgs()
{
if (_fileFormatVersion >= 25)
{
var extendedEvent = new ExtendedPropertyReassignmentEventArgs(
var reassignmentMessage = GetPropertyReassignmentMessage(propertyName, newValue, previousValue, $"{fields.File} ({fields.LineNumber},{fields.ColumnNumber})");
var reassignmentEvent = new PropertyReassignmentEventArgs(
propertyName,
previousValue,
newValue,
fields.File,
fields.LineNumber,
fields.ColumnNumber,
GetPropertyReassignmentMessage(propertyName, newValue, previousValue, $"{fields.File} ({fields.LineNumber},{fields.ColumnNumber})"));
// the message contains the location
reassignmentMessage,
reassignmentMessage);

SetCommonFields(extendedEvent, fields);
SetCommonFields(reassignmentEvent, fields);

return extendedEvent;
return reassignmentEvent;
}
else
{
Expand Down Expand Up @@ -1437,17 +1437,11 @@ private BuildEventArgs ReadPropertyInitialValueSetEventArgs()
message = FormatResourceStringIgnoreCodeAndKeyword(Strings.PropertyAssignment, propertyName, propertyValue, formattedSource);
}

var e = new ExtendedPropertyInitialValueSetEventArgs(
var e = new PropertyInitialValueSetEventArgs(
propertyName,
propertyValue,
propertySource,
fields.File,
fields.LineNumber,
fields.ColumnNumber,
message,
fields.HelpKeyword,
fields.SenderName,
fields.Importance);
message);
SetCommonFields(e, fields);

return e;
Expand Down

This file was deleted.

This file was deleted.