Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace psycopg2 with psycopg2-binary? #2943

Open
grahamalama opened this issue Jan 24, 2022 · 0 comments
Open

Replace psycopg2 with psycopg2-binary? #2943

grahamalama opened this issue Jan 24, 2022 · 0 comments
Labels
question stale For marking issues as stale. Labeled issues will be closed soon if label is not removed.

Comments

@grahamalama
Copy link
Contributor

I'm opening this issues as a venue of discussion about whether we should replace psycopg2 with psycopg2-binary in this repo.

In #2942, we replaced psycopg-binary with psycopg2 in requirements.txt, since kinto[postgresql] requires psycopg2 specifically.

In the comments of that PR, we proposed to instead replace psycopg2 with psycopg-binary in requirements.txt and the dependencies of the postgresql extra. Doing so would make kinto builds even faster.

However, the psycopg2 documentation has some warnings about using psycopg2-binary in production.

TBD: which version of psycopg2 should we use in this repo?

@alexcottner alexcottner added the stale For marking issues as stale. Labeled issues will be closed soon if label is not removed. label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question stale For marking issues as stale. Labeled issues will be closed soon if label is not removed.
Projects
None yet
Development

No branches or pull requests

2 participants