Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider specifying more dependency versions in setup.cfg #2445

Open
dstaley opened this issue Mar 7, 2020 · 1 comment
Open

Consider specifying more dependency versions in setup.cfg #2445

dstaley opened this issue Mar 7, 2020 · 1 comment
Labels
stale For marking issues as stale. Labeled issues will be closed soon if label is not removed.

Comments

@dstaley
Copy link
Member

dstaley commented Mar 7, 2020

Earlier today, ujson updated to 2.0.0 which broke building on Windows. Since ujson is specified in setup.cfg without a version identifier, it will always install the latest version. We should probably consider specifying versions so that we don't run into scenarios like this. I don't know too much about python packaging, but it looks like we could at least specify a specific major version.

@hugovk
Copy link

hugovk commented Mar 7, 2020

Generally, although I don't think the majority do it, it's nevertheless fairly common in Python for libraries to specify a max version for dependencies, to avoid surprises with major versions, eg. some_package<5 if we know it currently works with version 4.

Specifically, we hope to have a fixed ujson 2.0.1 out tomorrow for this (and thanks again for the help on that!).

@leplatrem leplatrem mentioned this issue May 14, 2020
2 tasks
@alexcottner alexcottner added the stale For marking issues as stale. Labeled issues will be closed soon if label is not removed. label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale For marking issues as stale. Labeled issues will be closed soon if label is not removed.
Projects
None yet
Development

No branches or pull requests

3 participants