Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: where the "source" field is officially defined? #10

Closed
josecelano opened this issue Aug 3, 2023 · 2 comments
Closed

Question: where the "source" field is officially defined? #10

josecelano opened this issue Aug 3, 2023 · 2 comments

Comments

@josecelano
Copy link

Hi @Kimbatt, Im looking for an official BEP or something where the "source" field is defined. In the README says:

Source: Arbitrary text. Setting the source of a torrent can be used to produce a different info hash. Can be empty.

It`s the only information I have not about that field.

I'm trying to fix a bug on a project I'm contributing. The infohash is not generated well because the torrent has the field:

torrust/torrust-index#242

@Kimbatt
Copy link
Owner

Kimbatt commented Aug 3, 2023

Hi,
I saw this field in the qBittorrent torrent creator, that's why I've added it. Not sure if there is an official specification for this.

Relevant part from qBittorrent: https://github.com/qbittorrent/qBittorrent/blob/master/src/base/bittorrent/torrentcreatorthread.cpp#L203
Which was added by this commit: qbittorrent/qBittorrent@8dcf326
Which was implemented because of this issue: qbittorrent/qBittorrent#7965

Mentioned in that issue: https://github.com/kz26/dottorrent/blob/master/dottorrent/__init__.py#L78
Which was added by this commit: kz26/dottorrent@dbc2a26

I also found these:
https://redd.it/93sepm
https://redd.it/jjq02i
https://redd.it/ppo9q2

I think the info dictionary can contain arbitrary keys in addition to the specified ones (but not sure about this, couldn't find anything official).

@josecelano
Copy link
Author

Hi, I saw this field in the qBittorrent torrent creator, that's why I've added it. Not sure if there is an official specification for this.

Relevant part from qBittorrent: https://github.com/qbittorrent/qBittorrent/blob/master/src/base/bittorrent/torrentcreatorthread.cpp#L203 Which was added by this commit: qbittorrent/qBittorrent@8dcf326 Which was implemented because of this issue: qbittorrent/qBittorrent#7965

Mentioned in that issue: https://github.com/kz26/dottorrent/blob/master/dottorrent/__init__.py#L78 Which was added by this commit: kz26/dottorrent@dbc2a26

I also found these: https://redd.it/93sepm https://redd.it/jjq02i https://redd.it/ppo9q2

I think the info dictionary can contain arbitrary keys in addition to the specified ones (but not sure about this, couldn't find anything official).

Hi @Kimbatt thank you very much! I have only taken a look at https://www.libtorrent.org/ (and its repo code) because I think qBitorrent is using it.

I've also opened a discussion on the qBittorrent repo: qbittorrent/qBittorrent#19406

I've reached the same conclusion as you that you can put everything in the info dictionary, but I wanted to know if there is an official BEP or the original reason why some clients are using it. As you mentioned, it seems the purpose is just to change the infohash due to the problem described here by @2wicked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants