Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a config to update ALLOWED_TLDS #18

Open
kuahyeow opened this issue Aug 24, 2023 · 1 comment
Open

Allow a config to update ALLOWED_TLDS #18

kuahyeow opened this issue Aug 24, 2023 · 1 comment

Comments

@kuahyeow
Copy link

Rather than updating the constant, and then waiting for a release, would it make sense to have a config option for gem users to configure the ALLOWED_TLDS ?

I guess users can update from http://data.iana.org/TLD/tlds-alpha-by-domain.txt, or customize as they require.

@kuahyeow
Copy link
Author

Oh wait, there's already a valid_tlds option that is at the validator level. So maybe we don't need a global config after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant