OpenCode v1.3.0 #8773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

catrielmuller wants to merge 169 commits into main from catrielmuller/kilo-opencode-v1.3.0

.github/actions/setup-bun/action.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -41,5 +41,13 @@ runs: @@
           shell: bash
         - name: Install dependencies
-          run: bun install
+          run: |
+            # Workaround for patched peer variants
+            # e.g. ./patches/ for standard-openapi
+            # https://github.com/oven-sh/bun/issues/28147
+            if [ "$RUNNER_OS" = "Windows" ]; then
+              bun install --linker hoisted
+            else
+              bun install
+            fi
           shell: bash

.github/workflows/test.yml

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -52,20 +52,17 @@ jobs:
  
        # kilocode_change - disabled: packages/app is not actively maintained

        if: false

        name: e2e (${{ matrix.settings.name }})

        needs: unit

        strategy:

          fail-fast: false

          matrix:

            settings:

              - name: linux

                host: blacksmith-4vcpu-ubuntu-2404

                playwright: bunx playwright install --with-deps

              - name: windows

                host: blacksmith-4vcpu-windows-2025

                playwright: bunx playwright install

        runs-on: ${{ matrix.settings.host }}

        env:

          PLAYWRIGHT_BROWSERS_PATH: 0

          PLAYWRIGHT_BROWSERS_PATH: ${{ github.workspace }}/.playwright-browsers

        defaults:

          run:

            shell: bash

    @@ -78,9 +75,28 @@ jobs:
  
          - name: Setup Bun

            uses: ./.github/actions/setup-bun

          - name: Read Playwright version

            id: playwright-version

            run: |

              version=$(node -e 'console.log(require("./packages/app/package.json").devDependencies["@playwright/test"])')

              echo "version=$version" >> "$GITHUB_OUTPUT"

          - name: Cache Playwright browsers

            id: playwright-cache

            uses: actions/cache@v4

            with:

              path: ${{ github.workspace }}/.playwright-browsers

              key: ${{ runner.os }}-${{ runner.arch }}-playwright-${{ steps.playwright-version.outputs.version }}-chromium

          - name: Install Playwright system dependencies

            if: runner.os == 'Linux'

            working-directory: packages/app

            run: bunx playwright install-deps chromium

          - name: Install Playwright browsers

            if: steps.playwright-cache.outputs.cache-hit != 'true'

            working-directory: packages/app

            run: ${{ matrix.settings.playwright }}

            run: bunx playwright install chromium

          - name: Run app e2e tests

            run: bun --cwd packages/app test:e2e:local

.kilo/plans/1775851318486-tidy-comet.md

-Original file line number
+Diff line change
@@ -0,0 +1,121 @@
+    # Re-implement kilocode changes on new `packages/opencode/src/permission/next.ts`
+    ## Context
+    The upstream `next.ts` was refactored to use an Effect-based `PermissionService` (`service.ts`). The old kilocode changes were lost. The new `next.ts` is a thin adapter that delegates to `service.ts` via `runPromise`. We need to re-add all kilocode-specific functionality.
+    The old kilocode changes provided:
+. **`toConfig()`** — inverse of `fromConfig`, converts rules back to config format
+. **`saveAlwaysRules()`** — granular always-allow/deny rule persistence (used by `/permission/:requestID/always-rules` route)
+. **`allowEverything()`** — toggle allow-all mode per-session or globally (used by `/permission/allow-everything` route)
+. **`pending()`** — get a single pending request by ID
+. **Config protection** — force "ask" for config file edits, disable "always" for config files
+. **Session-scoped rules** — `s.session[sessionID]` local ruleset evaluated alongside approved rules
+. **Null sentinel filtering** in `fromConfig` — skip `null` entries from config patches
+. **`drainCovered()`** integration — auto-resolve sibling pending permissions after rule changes
+. **`ruleset` stored on `PendingEntry`** — needed by `drainCovered` and `saveAlwaysRules`
+. **Persist always-rules to global config** in `reply("always")`
+    ## Architecture Decision
+    The new code splits into two layers:
+    - **`service.ts`** — Effect-based `PermissionService` with `ask`, `reply`, `list` (upstream code)
+    - **`next.ts`** — namespace adapter that wraps `service.ts` and adds non-Effect exports
+    **Strategy**: Add kilocode features in `next.ts` (the adapter layer) to minimize changes to shared `service.ts`. Where service-level changes are unavoidable (e.g., storing `ruleset` on `PendingEntry`, adding `session` to state, config protection in `ask`/`reply`), annotate them with `kilocode_change` markers in `service.ts`.
+    ## Changes
+    ### 1. `packages/opencode/src/permission/service.ts` — Minimal shared-code changes
+    These changes are necessary because the service owns the state and Effect logic:
+    #### 1a. Add `session` to `State` type
+    ```ts
+    type State = {
+      pending: Map<PermissionID, PendingEntry>
+      approved: Ruleset
+      session: Record<string, Ruleset> // kilocode_change
+    }
+    ```
+    Initialize `session: {}` in the `InstanceState.make` factory.
+    #### 1b. Add `ruleset` to `PendingEntry`
+    ```ts
+    interface PendingEntry {
+      info: Request
+      ruleset: Ruleset // kilocode_change
+      deferred: Deferred.Deferred<void, RejectedError | CorrectedError>
+    }
+    ```
+    Store `ruleset` when creating pending entries in `ask`.
+    #### 1c. Config protection in `ask`
+    - Import `ConfigProtection` from `@/kilocode/permission/config-paths`
+    - Evaluate with `local` session rules: `evaluate(permission, pattern, ruleset, state.approved, local)`
+    - After evaluating `allow`, check `ConfigProtection.isRequest(request)` and if true, override to `ask` behavior
+    - Inject `disableAlways` metadata key when config-protected
+    #### 1d. Config protection in `reply("always")`
+    - Import `ConfigProtection`
+    - Before persisting always-rules, check `ConfigProtection.isRequest(existing.info)` — if true, downgrade to `once` (resolve deferred, return early)
+    - When evaluating pending siblings after "always", include `item.ruleset` in `evaluate()` call
+    - After resolving pending siblings, persist always-rules to global config via `Config.updateGlobal`
+    #### 1e. Export new service methods on `PermissionService.Api`
+    Add to the interface:
+    - `saveAlwaysRules`
+    - `allowEverything`
+    - `pending`
+    Implement them inside the `Layer.effect` block as Effect functions.
+    #### 1f. `DeniedError` constructor compatibility
+    The old `DeniedError` accepted a `Ruleset` directly. The new one uses `Schema.TaggedErrorClass` with `{ ruleset: Schema.Any }`. The `drain.ts` currently calls `new DeniedError(ruleset)` — need to update to `new DeniedError({ ruleset })` in `drain.ts`, or keep compatibility. Since `drain.ts` is kilocode-owned, update `drain.ts`.
+    ### 2. `packages/opencode/src/permission/next.ts` — Adapter additions
+    #### 2a. Add `toConfig()` function
+    Port the `toConfig` implementation with `SCALAR_ONLY_PERMISSIONS` set. This is a pure function that doesn't need the service.
+    #### 2b. Add null sentinel filtering to `fromConfig()`
+    Add `if (value === null) continue` after the string check, and filter nulls from object entries.
+    #### 2c. Add `saveAlwaysRules` export
+    Delegate to `runPromise((service) => service.saveAlwaysRules(input))`.
+    #### 2d. Add `allowEverything` export
+    Delegate to `runPromise((service) => service.allowEverything(input))`.
+    #### 2e. Add `pending` export
+    Delegate to `runPromise((service) => service.pending(input))`.
+    ### 3. `packages/opencode/src/kilocode/permission/drain.ts` — Update for new types
+    The `drain.ts` file needs to be updated for the new architecture:
+    - The `PendingEntry` now uses `Deferred` instead of `resolve`/`reject` callbacks
+    - `DeniedError` is now an Effect `TaggedErrorClass` requiring `new DeniedError({ ruleset })`
+    - **Option A**: Rewrite `drainCovered` as an Effect function that receives the state and uses `Deferred.succeed`/`Deferred.fail`
+    - **Option B**: Keep `drainCovered` as a plain async function but adapt the interface
+    Since `drain.ts` is kilocode-only code, **Option A** is cleaner — rewrite it as an Effect function that operates directly on the `State` type from `service.ts`.
+    ### 4. No changes needed
+    - `config-paths.ts` — unchanged, works as-is
+    - `routes.ts` — unchanged, already calls `PermissionNext.allowEverything`, `PermissionNext.toConfig`
+    - `server/routes/permission.ts` — unchanged, already calls `PermissionNext.saveAlwaysRules`
+    ## File change summary
+    | File | Type | Description |
+    |------|------|-------------|
+    | `packages/opencode/src/permission/service.ts` | Modify (shared) | Add session state, ruleset on PendingEntry, config protection, new service methods, persist always-rules |
+    | `packages/opencode/src/permission/next.ts` | Modify (shared) | Add toConfig, null filtering in fromConfig, delegate new methods |
+    | `packages/opencode/src/kilocode/permission/drain.ts` | Modify (kilo) | Adapt to Effect Deferred + new DeniedError constructor |
+    ## Verification
+    - `bun run typecheck` from `packages/opencode/`
+    - `bun test` from `packages/opencode/` to ensure no regressions
+    - Verify the permission routes still compile by checking the server builds

.opencode/.gitignore

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -1,4 +1,6 @@
  
    plans/

    bun.lock

    node_modules

    plans

    package.json

    package-lock.json

    bun.lock

    .gitignore

    package-lock.json

.opencode/tool/github-pr-search.ts

-Original file line number
+Diff line change
@@ -1,6 +1,5 @@
     /// <reference path="../env.d.ts" />
     import { tool } from "@kilocode/plugin"
-    import DESCRIPTION from "./github-pr-search.txt"
     async function githubFetch(endpoint: string, options: RequestInit = {}) {
       const response = await fetch(`https://api.github.com${endpoint}`, {
@@ Expand All / @@ -24,7 +23,16 @@ interface PR { @@
     }
     export default tool({
-      description: DESCRIPTION,
+      description: `Use this tool to search GitHub pull requests by title and description.
+    This tool searches PRs in the anomalyco/opencode repository and returns LLM-friendly results including:
+    - PR number and title
+    - Author
+    - State (open/closed/merged)
+    - Labels
+    - Description snippet
+    Use the query parameter to search for keywords that might appear in PR titles or descriptions.`,
       args: {
         query: tool.schema.string().describe("Search query for PR titles and descriptions"),
         limit: tool.schema.number().describe("Maximum number of results to return").default(10),
@@ Expand Down @@

.opencode/tool/github-pr-search.txt

This file was deleted.

.opencode/tool/github-triage.ts

-Original file line number
+Diff line change
@@ -1,7 +1,21 @@
     /// <reference path="../env.d.ts" />
-    // import { Octokit } from "@octokit/rest"
-    import { tool } from "@kilocode/plugin"
-    import DESCRIPTION from "./github-triage.txt"
+    import { tool } from "@opencode-ai/plugin"
+    // kilocode_change start
+    const TEAM = {
+      desktop: ["kirillk"],
+      zen: ["chrarnoldus"],
+      tui: ["alex-alecu", "marius-kilocode", "catrielmuller"],
+      core: ["alex-alecu", "marius-kilocode", "catrielmuller"],
+      docs: ["lambertjosh"],
+      windows: ["imanolmzd-svg", "kirillk"],
+    } as const
+    // kilocode_change end
+    const ASSIGNEES = [...new Set(Object.values(TEAM).flat())]
+    function pick<T>(items: readonly T[]) {
+      return items[Math.floor(Math.random() * items.length)]!
+    }
     function getIssueNumber(): number {
       const issue = parseInt(process.env.ISSUE_NUMBER ?? "", 10)
@@ Expand All @@
     }
     export default tool({
-      description: DESCRIPTION,
+      description: `Use this tool to assign and/or label a GitHub issue.
+    Choose labels and assignee using the current triage policy and ownership rules.
+    Pick the most fitting labels for the issue and assign one owner.
+    If unsure, choose the team/section with the most overlap with the issue and assign a member from that team at random.`,
       args: {
         assignee: tool.schema
           .enum(["thdxr", "adamdotdevin", "rekram1-node", "fwang", "jayair", "kommander"])
@@ Expand Down @@

.opencode/tool/github-triage.txt

This file was deleted.

Navigation Menu

Uh oh!

OpenCode v1.3.0 #8773

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!

Uh oh!

Uh oh!