fix cli ephemeral mode config leak #4251
Merged
+130
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ephemeral check only existed and was used in loadConfig, so any subsequent things that triggered saveConfig still caused the env vars to update the config.
🦋 Changeset detectedLatest commit: f5a7204 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
catrielmuller
approved these changes
Dec 6, 2025
This was referenced Dec 5, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The ephemeral check only existed and was used in loadConfig, so any subsequent things that triggered saveConfig still caused the env vars to update the config.
Implementation
saveConfig now explicitly checks for isEphemeralMode before writing the config.
Screenshots
How to Test
Get in Touch