fix(tools): improve tool calling consistency #3261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bae048f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Adjust tool inclusion behavior in getAllowedJSONToolsForMode() to correctly handle apply_diff behaviors. - Emphasize tool use requirements in tool-use section - Remove XML-specific references in markdown rules (attempt_completion) to avoid pollution of the context. - Update all 8 system prompt test snapshots to match changes
chrarnoldus
reviewed
Oct 23, 2025
mcowger
force-pushed
the
mcowger/smallToolFixes
branch
from
1501c7a to
6086853
Compare
Contributor
Author
|
Updated this to address @chrarnoldus comments. However the test failure for windows seems unrelated to the changes I made, even after rebasing. |
chrarnoldus
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get in Touch
mcowger