diff --git a/.changeset/documents-open-in-editor.md b/.changeset/documents-open-in-editor.md new file mode 100644 index 000000000000..850139650eb3 --- /dev/null +++ b/.changeset/documents-open-in-editor.md @@ -0,0 +1,5 @@ +--- +"kilo-code": patch +--- + +Fix Open in Editor button in Documents viewer diff --git a/packages/kilo-vscode/src/review-utils.ts b/packages/kilo-vscode/src/review-utils.ts index 22e9752a546f..15ee093dcd35 100644 --- a/packages/kilo-vscode/src/review-utils.ts +++ b/packages/kilo-vscode/src/review-utils.ts @@ -1,3 +1,4 @@ +import * as path from "path" import * as vscode from "vscode" import { resolveInside } from "./diff/shared/path" import { inspect } from "util" @@ -37,8 +38,7 @@ export function openFileInEditor( } export function openRelativeFile(root: string | undefined, relativePath: string, line?: number, column?: number): void { - if (!root) return - const resolved = resolveInside(root, relativePath) + const resolved = path.isAbsolute(relativePath) ? relativePath : root && resolveInside(root, relativePath) if (!resolved) return openFileInEditor(resolved, line, column, vscode.ViewColumn.Beside, "DiffPanel") } diff --git a/packages/kilo-vscode/tests/unit/review-utils.test.ts b/packages/kilo-vscode/tests/unit/review-utils.test.ts index f6573d561163..2d4cb43fa27e 100644 --- a/packages/kilo-vscode/tests/unit/review-utils.test.ts +++ b/packages/kilo-vscode/tests/unit/review-utils.test.ts @@ -40,4 +40,16 @@ describe("openRelativeFile", () => { expect(execute).not.toHaveBeenCalled() }) + + it("opens absolute paths directly, even without a root", () => { + openRelativeFile(undefined, "/repo/app_alpha/README.md") + + expect((execute.mock.calls[0]?.[1] as vscode.Uri).fsPath).toBe("/repo/app_alpha/README.md") + }) + + it("opens absolute paths that fall outside the selected repository", () => { + openRelativeFile("/repo/app_alpha", "/repo/app_beta/README.md") + + expect((execute.mock.calls[0]?.[1] as vscode.Uri).fsPath).toBe("/repo/app_beta/README.md") + }) })