Full Screen Support

[LaatonWalaBhoot]

Hi, great work on the library. Would it be possible to allow full-screen support to the Youtube Videos?

[KhubaibKhan4]

Yes, we can display videos in a full screen but it's working in Web right now. In the upcoming update, I'll definitely add the full screen support for all the platforms. Thank you for your suggestion.

[LaatonWalaBhoot]

I have a few other questions. Sorry to bother you but is it possible to display youtube videos in a LazyColumn?
And does it preserve the video state while scrolling?
I could not find a sample. Should I open a separate issue for this? @KhubaibKhan4

[KhubaibKhan4]

Thank you for another suggestion. Yeah, we can display youtube videos inside the lazy column as well but there's no official support for playing youtube videos. We're using JavaFx e.g, So we're it didn't persist the video state.

[LaatonWalaBhoot]

Is it possible to persist Video state like Twitter does?
With an Android webview the issue that I face is it causes reload on scrolling
Plus the webview is itself unscrollable and hogs all touches of the lazy column

[KhubaibKhan4]

There's only way to hold the state using mutableMapState. by that we can hold the current Video Ids and return when we revisit them. This method is mostly used in applications to persist the data. I'll try to include the persistence of video players in YouTube. It's do it.

[LaatonWalaBhoot]

That would be great. Any idea about the timeline for this @KhubaibKhan4 ?

[KhubaibKhan4]

I'm planning to work on a sprint of 15 days. Hopefully, will achieve in this sprint.

[LaatonWalaBhoot]

Any update on this @KhubaibKhan4 ?

[KhubaibKhan4]

Unfortunately, I'm busy with tickets. Will be doing soon.

[LaatonWalaBhoot]

No worries. Looking forward to it.

[LaatonWalaBhoot]

@KhubaibKhan4 saw that you marked it as completed but I couldn't find the functionality

[KhubaibKhan4]

I accidentally closed this issue. Let me add the functionality of full screen as well.

[Vaibhav2002]

@KhubaibKhan4 I tried the latest release, which seems to have the "FullScreen Youtube Player" feature
But it is not working, when i click the fullscreen button nothing happens, also the fullscreen button becomes unresponsive after the first click

[KhubaibKhan4]

@Vaibhav2002 Thank you for your comment. Let me checkout these issues. I'll fix it asap.

[KhubaibKhan4]

@LaatonWalaBhoot @Vaibhav2002 Thank you for creating the issue. I just added this on the latest version and just updating the version on the Maven Central.

[Vaibhav2002]

Hey @KhubaibKhan4
I tried the latest release 1.1.2, and the fullscreen player still does not work.

Screen.Recording.2024-09-23.at.11.55.49.AM.mov

[KhubaibKhan4]

Let me check it out again.

[LaatonWalaBhoot]

@KhubaibKhan4 Any update on this?

[KhubaibKhan4]

Tonight, I'll release a new version. Sore for the delay

[LaatonWalaBhoot]

That's great. Thanks. Waiting for it eagerly

[KhubaibKhan4]

Checkout the latest version, Now the full screen is working fine.

[Vaibhav2002]

@KhubaibKhan4 I tried 1.1.4, and it still does not work

[KhubaibKhan4]

@Vaibhav2002 Please check again. It's working fine. Please verify it on your emulator or a Personal Device. Thank you

[Vaibhav2002]

@KhubaibKhan4 It does not work in emulator as well as my personal device, I am using 1.1.4.
It works on iOS though, but not on Android

Screen_Recording_20240926_135610.mp4

[KhubaibKhan4]

@Vaibhav2002 Thank you for providing the evidence, I'll check it out and will update here asap. Thank you for being valuable by providing feedback.

[Vaibhav2002]

@KhubaibKhan4 i tried 1.1.5 , it still does not work, the same thing happens as shown in the recording i sent before
The button does nothing

[KhubaibKhan4]

Checkout the latest version. Full Screen Is working. Checkout the linkedin post: https://www.linkedin.com/posts/khubaibkhandev_kmp-cmp-kotlin-activity-7246938312261746689-HrL3?utm_source=share&utm_medium=member_desktop

Please share your feedback and recommendations as well.

[Vaibhav2002]

@KhubaibKhan4 it is working on my personal device but it seems to be a bit buggy
The screen rotates but the video player is not fullscreen, also it feels quite janky even in release build

Screen_Recording_20241003_125010.mp4

[KhubaibKhan4]

Please try it on some other devices and let me know, So I can check out the issue because it's working fine on my Personal Device as well as on the emulators.

[LaatonWalaBhoot]

@KhubaibKhan4 I'm having the same issue in my Samsung device

[Vaibhav2002]

@KhubaibKhan4 i tried on multiple physical devices, its the same everywhere.

[KhubaibKhan4]

@LaatonWalaBhoot @Vaibhav2002 I'll checkout and will let you know.

[Vaibhav2002]

@KhubaibKhan4 any update on this?

[KhubaibKhan4]

@Vaibhav2002 It's still working fine on my Emulator and my personal device. Please provide me the issue that you are facing. Make sure to checkout the videos on the Network Connection as well as Wifi Connection.

[LaatonWalaBhoot]

@KhubaibKhan4 I am having the issue on all networks in my Samsung device

[Vaibhav2002]

@KhubaibKhan4 I tried the latest update on both emulator, physical device as well as wifi and mobile network
It still behaves the same as the last recording I sent, but this release has another bug where video in fullscreen goes completely white and the back button stops working

Screen_Recording_20241011_132310.mp4

[KhubaibKhan4]

Thank you for your video. I'm looking in to it and provide an update asap. Thank you 🙏

[Vaibhav2002]

@KhubaibKhan4 I tried the new release and the issue is still there
Still my screen rotates, but video player is not fullscreen
and clicking fullscreen button makes screen go white

Exactly same as the recording i sent