Skip to content

Confirm color encoding for spec-gloss and sheen textures #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lexaknyazev opened this issue Feb 15, 2021 · 1 comment
Closed

Confirm color encoding for spec-gloss and sheen textures #295

lexaknyazev opened this issue Feb 15, 2021 · 1 comment
Assignees
@UX3D-becher

Comments

@lexaknyazev
Copy link
Member

As per the glTF extension specs, specularGlossinessTexture and sheenColorTexture use sRGB encoding.

The sample-viewer doesn't mark them as non-linear:
https://github.com/ux3d/glTF-Sample-Viewer/blob/develop/source/gltf/material.js#L493
https://github.com/ux3d/glTF-Sample-Viewer/blob/develop/source/gltf/material.js#L527
@UX3D-becher
Copy link
Contributor

thanks for reporting this, we fixed it with commit 68eb9d2

@lexaknyazev lexaknyazev mentioned this issue Jan 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@UX3D-becher UX3D-becher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lexaknyazev @UX3D-becher