Do not translate arbitrary precision operations without corresponding extensions #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… extensions This patch addresses KhronosGroup#653 (comment) If the appropriate extension for arbitrary precision instruction is not enabled, invalid IR will be produced. Report an error in this case.
Contributor
|
@AlexeySotkin this fix addresses your comment #653 (comment). Could you please review it? |
Contributor
|
Tagging @AlexeySachkov @MrSidims for review. |
MrSidims
approved these changes
Aug 27, 2020
MrSidims
reviewed
Aug 27, 2020
Contributor
MrSidims
left a comment
MrSidims
left a comment
There was a problem hiding this comment.
I think a test shall be added in test/negative directory.
test/transcoding/capability-arbitrary-precision-fixed-point-numbers.ll
Outdated
Show resolved
Hide resolved
AlexeySachkov
approved these changes
Sep 8, 2020
svenvh
pushed a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Nov 4, 2020
… extensions (KhronosGroup#714) This patch addresses [comment][1] If the appropriate extension for arbitrary precision instruction is not enabled, invalid IR will be produced. Report an error in this case. [1]: KhronosGroup#653 (comment)
svenvh
pushed a commit
that referenced
this pull request
Nov 12, 2020
… extensions (#714) This patch addresses [comment][1] If the appropriate extension for arbitrary precision instruction is not enabled, invalid IR will be produced. Report an error in this case. [1]: #653 (comment)
DmitryBushev
pushed a commit
to DmitryBushev/SPIRV-LLVM-Translator
that referenced
this pull request
Sep 1, 2021
… extensions (KhronosGroup#714) This patch addresses [comment][1] If the appropriate extension for arbitrary precision instruction is not enabled, invalid IR will be produced. Report an error in this case. [1]: KhronosGroup#653 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses #653 (comment)
If the appropriate extension for arbitrary precision instruction is not enabled, invalid IR will be produced. Report an error in this case.