[SPIR-V 1.4] Allow OpCopyMemorySized to have Memory Operands for both Source and Target #2470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Source and Target
Contributor
Author
|
Please take a look @MrSidims @LU-JOHN @asudarsa @bwlodarcz @VyacheslavLevytskyy |
svenvh
reviewed
Apr 3, 2024
Member
svenvh
left a comment
svenvh
left a comment
There was a problem hiding this comment.
LGTM, thanks for working on this! I have just one small naming suggestion.
svenvh
approved these changes
Apr 3, 2024
MrSidims
approved these changes
Apr 3, 2024
Contributor
MrSidims
left a comment
MrSidims
left a comment
There was a problem hiding this comment.
Thanks! BTW it's worth cherry-picking in older branches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses p.4 of #2460.
No changes for
OpCopyMemoryas we currently don't use it in translation.