Add error checking for cooperative matrix use and scope parameters #2223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrSidims
changed the title
MrSidims
force-pushed
the
matrix-use-error
branch
from
f7792c4 to
048bf60
Compare
MrSidims
changed the title
MrSidims
force-pushed
the
matrix-use-error
branch
from
048bf60 to
b76d1c7
Compare
Use should be: MatrixA, MatrixB or Accumulator. Scope must be at max Invocation (others are not supported by the translator). Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims
force-pushed
the
matrix-use-error
branch
from
b76d1c7 to
fb26884
Compare
Contributor
Author
|
@vmaksimo @VyacheslavLevytskyy please take a look |
vmaksimo
reviewed
Nov 23, 2023
Contributor
|
looks good |
Signed-off-by: Sidorov, Dmitry <[email protected]>
fda0
pushed a commit
to fda0/SPIRV-LLVM-Translator
that referenced
this pull request
May 22, 2025
…ope parameters (KhronosGroup#2223) Use should be: MatrixA, MatrixB or Accumulator. Scope must be at max Invocation (others are not supported by the translator). Signed-off-by: Sidorov, Dmitry <[email protected]> (cherry picked from commit f18e64d)
bokrzesi
pushed a commit
to bokrzesi/SPIRV-LLVM-Translator
that referenced
this pull request
Jun 11, 2025
…hronosGroup#2223) Use should be: MatrixA, MatrixB or Accumulator. Scope must be at max Invocation (others are not supported by the translator). Signed-off-by: Sidorov, Dmitry <[email protected]> (cherry picked from commit f18e64d)
bokrzesi
pushed a commit
to bokrzesi/SPIRV-LLVM-Translator
that referenced
this pull request
Jun 11, 2025
…hronosGroup#2223) Use should be: MatrixA, MatrixB or Accumulator. Scope must be at max Invocation (others are not supported by the translator). Signed-off-by: Sidorov, Dmitry <[email protected]> (cherry picked from commit f18e64d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use should be: MatrixA, MatrixB or Accumulator.
Scope must be at max Invocation (others are not supported
by the translator).
Signed-off-by: Sidorov, Dmitry [email protected]