ktx create: Update transfer function handling #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INT SCALED and ASTC_SFLOAT are all very different from a sRGB value.
The old names are retained, deprecated, for backwards compatibility.
Document ktxTexture2_Set{OETF,Transfer,Primaries}.
Functionally complete. New functionality remains to be tested.
* Clean up that function. * Fix error in texcoord origin related error message.
Update printdfd to handle newly added transfer function.
Document --no-warn-on-color-conversions in --help text.
MarkCallow
force-pushed
the
update_tf_handling
branch
from
b98b960 to
5b1a50e
Compare
Disallow prohibited formats before attempting to make a dfd when creating a new texture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support in ktx create the transfer function flexibility opened up by spec. revision 2.
Note to reviewers
I suggest starting by reading the new Transfer Function Handling section of the documentation starting at line 1029 in tools/ktx/command_create.cpp. . This will give you an overview of what the updates are supposed to do and also lists the changes from the current version.
There are some unrelated changes:
I took the opportunity to fix these here rather than making another PR.