Open
Conversation
|
Some people will not use npm to install the package (e.g. install from GitHub url) – would that still work if src is ignored? |
Contributor
Author
|
People shouldn't really be using But if there's a valid use case, happy to exclude and continue to ship |
|
I'm really not sure I am not knowledgable enough on the topic, was purely a question if it would still work |
Contributor
Author
Yep should still work. npmignore is just for files to ignore during the npm publish process |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
.npmignorefile to not publish files and dirs that aren't used by consumers. This simplified the distributed binaries but the main motivation for this change is that.flowconfigis included when aphrodite is published. Which if I browse the files within node_modules, flow server will crash because it detects multiple upstream flow configs.@lencioni @jlfwong