Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ng-katex link to readme.md #959

Merged
merged 2 commits into from
Nov 11, 2017
Merged

Conversation

garciparedes
Copy link
Contributor

@garciparedes garciparedes commented Nov 11, 2017

From issue #688

@khanbot
Copy link

khanbot commented Nov 11, 2017

Hey @garciparedes,

Thanks for the PR! Mind signing our Contributor License Agreement?

When you've done so, go ahead and comment [clabot:check] and I'll check again.

Yours truly,
khanbot

@garciparedes
Copy link
Contributor Author

[clabot:check]

@khanbot
Copy link

khanbot commented Nov 11, 2017

CLA signature looks good 👍

Copy link
Member

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -86,6 +86,12 @@ the same aspect ratio in KaTeX as in LaTeX. However, because most browsers
default to a larger font size, this typically means that a 1cm kern in KaTeX
will appear larger than 1cm in browser units.

## Libraries
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this section. I'm sure we'll be expand this to include other libraries/components.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps katex-ruby from @glebm would be a good addition.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Also, wasn't there a KA plugin of some relevance?

@kevinbarabash kevinbarabash merged commit 067697e into KaTeX:master Nov 11, 2017
@kevinbarabash
Copy link
Member

@garciparedes thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants