Remove the positions array computed by Parser's parseArguments(). #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcianx
commented
Sep 10, 2017
| * List of ParseNodes followed by an array of positions. | ||
| * Returned by `Parser`'s `parseArguments`. | ||
| */ | ||
| type ParseResult = (ParseNode | number[])[] | ParseNode; |
There was a problem hiding this comment.
FYI: I'd confused myself in the last PR where I used this as the type: I'd confused the local parseArray method with Parser's parseArguments method. Sorry about that.
This array is computed incorrectly (it's always an array of undefineds) and it's not used anywhere.
marcianx
force-pushed
the
nuke-positions
branch
from
1365798
to
406e620
Compare
kevinbarabash
approved these changes
Sep 10, 2017
|
@marcianx thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This array is computed incorrectly (it's always an array of undefineds) and it's not used anywhere. See #863 for details.