Fix exponential behavior in accent production #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it. |
| @@ -453,7 +461,7 @@ const svgSpan = function(group, options) { | |||
| if (utils.contains(["widehat", "widetilde", "undertilde"], label)) { | |||
| // There are four SVG images available for each function. | |||
| // Choose a taller image when there are more characters. | |||
| const numChars = group.value.value.length; | |||
| const numChars = groupLength(group.value.base); | |||
There was a problem hiding this comment.
Stretchy accents use body instead of base. Probably best to make them use the same thing. I have a slight preference for body because base makes me think of exponents, but either would be fine.
sophiebits
force-pushed
the
noexp
branch
3 times, most recently
from
3f05d53
to
4aa87b7
Compare
src/functions.js was returning two properties referring to the base; since buildHTML runs `JSON.parse(JSON.stringify(tree))` to get an immutable copy, that meant we'd traverse and serialize and parse an exponentially-sized tree.
Test Plan: `\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{A}}}}}}}}}}}}}}}}}}}}}}}}}}}}}}}}}}` renders instantly; previously, it reliably timed out with even half that depth.
|
Opted for if (shouldHandleSupSub(group, options)) {
return groupTypes[group.value.base.type](group, options);
}which currently relies on |
kevinbarabash
approved these changes
Aug 30, 2017
|
@sophiebits thanks for finding this issue and fixing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/functions.js was returning two properties referring to the base; since buildHTML runs
JSON.parse(JSON.stringify(tree))to get an immutable copy, that meant we'd traverse and serialize and parse an exponentially-sized tree.Test Plan:
\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{\breve{A}}}}}}}}}}}}}}}}}}}}}}}}}}}}}}}}}}renders instantly; previously, it reliably timed out with even half that depth.