Support CJK full-width punctuation + Unicode dots #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The height for some of these characters is going to be wrong, but I think that's okay b/c there will almost always be non-punctuation CJK characters around them. |
|
I'm glad that this was easy to add. Thanks @edemaine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #812. Screenshot:
I found two unicode groups that were missing for the symbols that @zhzhzoo listed in #812:
[\u3000-\u303F][\uFF00-\uFF60]I also reformatted the regex more minimally. Happy to revert if that's not preferred, but I think the comment covers the intent pretty clearly. (Perhaps we should add the wiktionary links above?)
@zhzhzoo also listed "…" (U+2026) for ellipsis. This was easy to add using @kevinbarabash's new Unicode character functionality. While I was at it, I added support for all already-supported forms of ellipsis.