Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable error callback #658

Merged
merged 3 commits into from
Jul 30, 2017
Merged

Add configurable error callback #658

merged 3 commits into from
Jul 30, 2017

Conversation

joernlenoch
Copy link
Contributor

Replace console.error with a configurable option. This mimcs the current
default behaviour to guaranteee compatibility with previous versions.
Add errorCallback to the README.md

@khanbot
Copy link

khanbot commented Feb 13, 2017

Hey @j-lenoch,

Thanks for the PR! Mind signing our Contributor License Agreement?

When you've done so, go ahead and comment [clabot:check] and I'll check again.

Yours truly,
khanbot

1 similar comment
@khanbot
Copy link

khanbot commented Feb 13, 2017

Hey @j-lenoch,

Thanks for the PR! Mind signing our Contributor License Agreement?

When you've done so, go ahead and comment [clabot:check] and I'll check again.

Yours truly,
khanbot

Replace console.error with a configurable option. This mimcs the current
default behaviour to guaranteee compatibility with previous versions.
Update errorCallback to the README.md
@joernlenoch
Copy link
Contributor Author

[clabot:check]

@khanbot
Copy link

khanbot commented Feb 13, 2017

Hey @j-lenoch,

Thanks for the PR! Mind signing our Contributor License Agreement?

When you've done so, go ahead and comment [clabot:check] and I'll check again.

Yours truly,
khanbot

@edemaine
Copy link
Member

This looks like a nice feature to add, but we should first merge #656 which provides a general framework for defining options; then we can add an errorCallback to the options object.

@edemaine
Copy link
Member

@j-lenoch #656 finally landed. (Sorry for the delay.) Can you try to merge your feature addition onto the current master branch, e.g. via git rebase and resolving the conflict?

@joernlenoch
Copy link
Contributor Author

Thank you very much, I'll take care of it!

Copy link
Member

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the delay.

@kevinbarabash
Copy link
Member

@j-lenoch thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants