-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurable error callback #658
Conversation
Hey @j-lenoch, Thanks for the PR! Mind signing our Contributor License Agreement? When you've done so, go ahead and comment Yours truly, |
1 similar comment
Hey @j-lenoch, Thanks for the PR! Mind signing our Contributor License Agreement? When you've done so, go ahead and comment Yours truly, |
Replace console.error with a configurable option. This mimcs the current default behaviour to guaranteee compatibility with previous versions. Update errorCallback to the README.md
[clabot:check] |
Hey @j-lenoch, Thanks for the PR! Mind signing our Contributor License Agreement? When you've done so, go ahead and comment Yours truly, |
This looks like a nice feature to add, but we should first merge #656 which provides a general framework for defining options; then we can add an |
@j-lenoch #656 finally landed. (Sorry for the delay.) Can you try to merge your feature addition onto the current master branch, e.g. via |
Thank you very much, I'll take care of it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Sorry for the delay.
@j-lenoch thanks for the PR. |
Replace console.error with a configurable option. This mimcs the current
default behaviour to guaranteee compatibility with previous versions.
Add errorCallback to the README.md