Use utils.deflt for Settings #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than duplicate the definition of the undefined-defaulter, use the version already present in utils. Not sure why the `macros` line uses a different pattern, but I've left it alone. Happy to amend to make it match if desired.
|
CLA signature looks good 👍 |
|
I copied the import statement from one of the other files, but the linter complained about the use of |
|
Ah, yes, I forked on Dec 2nd and haven't re-upped yet. Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than duplicate the definition of the undefined-defaulter, use the version already present in utils.
Not sure why the
macrosline uses a different pattern, but I've left it alone. Happy to amend to make it match if desired.