Revert "Remove trailing commas for IE 9 compatibility" #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4d2e46e. Having trailing commans makes diffs easier to read as it avoids modifying a line just to add a trailing comma if there is another item to add at the end of a list. There are plans to switch to ES6 notation and to translate that to ES5 as part of the build process. Since that translation would remove trailing commas, the IE9 problems that originally motivated the commit should vanish soon.
This makes eslint happy again.
|
@xymostech are you waiting for some other input before merging? Do you want me to merge this myself? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4d2e46e.
Having trailing commans makes diffs easier to read as it avoids modifying a line just to add a trailing comma if there is another item to add at the end of a list. There are plans to switch to ES6 notation and to translate that to ES5 as part of the build process (#617). Since that translation would remove trailing commas, the IE9 problems that originally motivated the commit should vanish soon.