-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support \underline in text mode #1159
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1159 +/- ##
=======================================
Coverage 79.37% 79.37%
=======================================
Files 59 59
Lines 3865 3865
Branches 648 648
=======================================
Hits 3068 3068
Misses 662 662
Partials 135 135
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad this was a simple/quick fix!
@edemaine Meant to mention prior to approving. Perhaps we'd want to add a test for this? Might be able to add to the existing "Text" screenshot. |
I added a simple test to the LowerAccent one which currently tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the test. Glad this was a simple fix!
Fix #1158 with a one-line change. I could not find any other "long accents" that are supposed to work in text mode, but let me know if you find any!
Screenshot:
Comparison to LaTeX: