Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add \nobreakspace #1145

Merged
merged 1 commit into from
Feb 6, 2018
Merged

Add \nobreakspace #1145

merged 1 commit into from
Feb 6, 2018

Conversation

ronkok
Copy link
Collaborator

@ronkok ronkok commented Feb 6, 2018

No description provided.

@codecov
Copy link

codecov bot commented Feb 6, 2018

Codecov Report

Merging #1145 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1145      +/-   ##
==========================================
+ Coverage   78.94%   78.95%   +0.01%     
==========================================
  Files          59       59              
  Lines        3870     3872       +2     
  Branches      655      655              
==========================================
+ Hits         3055     3057       +2     
  Misses        674      674              
  Partials      141      141
Impacted Files Coverage Δ
src/symbols.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f977c25...ce39952. Read the comment docs.

Copy link
Member

@edemaine edemaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

I feel a little unsettled that \space and map to the same thing as \nobreakspace, but I guess that's the topic for another PR.

Do we want a Unicode mapping for one of these too?

@ronkok
Copy link
Collaborator Author

ronkok commented Feb 6, 2018

Do we want a Unicode mapping for one of these

Maybe not. One can already get a non-breaking space using ~. Also, unicode-math-table.txt contains no alias for U+00A0.

@edemaine edemaine merged commit 73d80f5 into KaTeX:master Feb 6, 2018
@edemaine
Copy link
Member

edemaine commented Feb 6, 2018

Sounds good; thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants