remove symlink to support devs using Windows #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinbarabash
commented
Jan 25, 2018
| @@ -1,62 +0,0 @@ | |||
| @font-folder: "fonts"; | |||
There was a problem hiding this comment.
This file has been moved to KaTeX/katex-fonts. See KaTeX/katex-fonts#10.
|
This will unblock #1078. |
ylemkimon
requested changes
Jan 25, 2018
There was a problem hiding this comment.
Works perfectly on Windows 10.
Following paths need to be updated:
https://github.com/Khan/KaTeX/blob/5f32b71c859d0ef48c349cb1fa00cf7e7fff808f/package.json#L57
https://github.com/Khan/KaTeX/blob/5f32b71c859d0ef48c349cb1fa00cf7e7fff808f/Makefile#L34
kevinbarabash
force-pushed
the
no_symlinks
branch
from
c1d9a9f
to
6362b9e
Compare
kevinbarabash
commented
Jan 29, 2018
| @@ -54,7 +54,7 @@ | |||
| }, | |||
| "bin": "cli.js", | |||
| "scripts": { | |||
| "lint": "eslint katex.js katex.webpack.js cli.js webpack.common.js webpack.config.js webpack.dev.js src test contrib dockers && stylelint static/fonts.less static/katex.less", | |||
There was a problem hiding this comment.
I'll make a separate PR to https://github.com/KaTeX/katex-fonts to lint fonts.less now that it's living in that repo.
kevinbarabash
force-pushed
the
no_symlinks
branch
from
6362b9e
to
5ec40ca
Compare
ylemkimon
approved these changes
Jan 29, 2018
|
@ylemkimon thanks for the review. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1052. KaTeX/katex-fonts#10 should also be reviewed and merged before merging this change.
Test Plan: