Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'common issues' section to the README #1034

Merged
merged 6 commits into from
Dec 27, 2017
Merged

Add a 'common issues' section to the README #1034

merged 6 commits into from
Dec 27, 2017

Conversation

kevinbarabash
Copy link
Member

Addressed #967, replaces #1020.

Copy link
Member

@edemaine edemaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely going to be a nice section to have. A good initial set. Just found a couple typos/issues.

README.md Outdated
standard line separator.
- KaTeX does not support the `align` environment because LaTeX doesn't support
`align` in math mode. You can define a macro that maps `align` to `aligned`
to work aroudn this.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo "aroudn". Also some readers may not be familiar with aligned (partly because it's amsmath, not regular LaTeX -- at least I didn't know about it until I learned KaTeX), so maybe a short introduction of "aligned offers the same functionality but in math mode, so use that instead" before mentioning macro option?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice rewrite!

README.md Outdated
have a "smart quotes" feature. This changes `'` to `’` which is an issue for
math containing primes, e.g. `f'`. This can be worked around by defining a
single character macro which changes them back, e.g. `{"’", "'"}`.
- KaTeX follows LaTeX's rendering of aligned and *matrix environments. When
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra * before "matrix". Should we add "unlike MathJax" here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to put *matrix inside backticks to get around the italics issues.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is *matrix? Maybe it's matrix*? (I'm just guessing based on LaTeX conventions.) Does this comment not apply to regular matrix? Also I'd suggest adding backticks to aligned to match.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't *matrix cover matrix, bmatrix, pmatrix, etc.? I guess in this case * is overloaded... I can just write all matrix environments.

Copy link
Member Author

@kevinbarabash kevinbarabash Dec 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to leave the all out.

@mbourne
Copy link

mbourne commented Dec 27, 2017

Small nit:

The distance between rows can be adjusted by using...

@edemaine edemaine merged commit d470cc0 into master Dec 27, 2017
@kevinbarabash kevinbarabash deleted the common-issues branch December 29, 2017 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants