-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-portable use of String method .includes
#1093
Comments
Hmm... |
I tried |
I checked |
Hmm, when I try it with less intervening Ruby layers, it works. Sorry, that's not your bug, even though it manifests at the Javascript execution level. Have to track it down myself. |
Use of the string method |
I'd propose to use |
Nice find! |
We'll definitely want to fix this before the next release. |
\mathbb{C}
.includes
* Adding support for SansSerif-Bold * Updating to include SansSerif Italic. * WIP * Working text stacking * More robust screenshot. * Don't want to break users :) * Updating per PR comments. * Fixing Unicode and updating snapshots. * Adding suggested tests. * Opting to use old method for unit testing. * Adding TODO
@ccorn if you have time, would definitely accept a PR to fix this. |
I'd like to do that, but I am not a Javascript expert, and I am not familiar with the build system around KaTeX. I can fork the repo, do a minimal |
Hmm, there is a Makefile. Known territory. OK, I'll ssh into a server that has Node available, and then try and clone and mess around a bit. |
KaTeX v0.9.0-beta chokes on
\mathbb{C}
(and\mathbb{R}
so it's probably the macro), telling me "undefined not callable".KaTeX v0.8.3 and v0.9.0-alpha2 render that without problems.
Found using
katex.renderToString
with Duktape.The text was updated successfully, but these errors were encountered: