Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter runs that after in_progress run #13

Merged
merged 4 commits into from
May 18, 2020

Conversation

Kesin11
Copy link
Owner

@Kesin11 Kesin11 commented May 18, 2020

Bugfix some case in_progress job never export.

build_id: 2, status: finished
build_id: 3, status: in_progress
build_id: 4, status: finished

Above case exports build_id: 2,4 and LastRunId will be detect 4 and store it. Next time fetch runs will start from build_id: 5. It means build_id: 3 never export.

This PR resolve this issue. In above case, exports only build_id: 2 and ignore build_id: 3, 4. Next time fetch runs will start from build_id: 3.

@Kesin11 Kesin11 force-pushed the feature/filter_after_in_progress_run branch from 535a7f2 to a063f9f Compare May 18, 2020 15:08
@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #13 into master will increase coverage by 0.80%.
The diff coverage is 75.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   50.79%   51.60%   +0.80%     
==========================================
  Files          10       12       +2     
  Lines         189      281      +92     
  Branches       37       56      +19     
==========================================
+ Hits           96      145      +49     
- Misses         92      135      +43     
  Partials        1        1              
Impacted Files Coverage Δ
src/client/circleci_client.ts 38.29% <62.50%> (ø)
src/client/github_client.ts 54.28% <81.25%> (ø)
src/client/jenkins_client.ts 56.75% <84.61%> (+23.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a06e008...a063f9f. Read the comment docs.

@Kesin11 Kesin11 merged commit 8c45ca3 into master May 18, 2020
@Kesin11 Kesin11 deleted the feature/filter_after_in_progress_run branch May 18, 2020 15:43
Kesin11 added a commit that referenced this pull request May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant