feat!: Return error exitCode when catch some errors

src/index.ts

@@ -16,6 +16,11 @@ const main = async () => {
   const yamlConfig = loadConfig(argv.c)
 
   const runner = new CompositRunner(yamlConfig)
-  await runner.run()
+  const result = await runner.run()
+
+  if (result.isFailure()) {
+    console.info('Some runners return error!')
+    process.exitCode = 1
+  }
 }
 main()

src/runner/circleci_runner.ts

@@ -9,6 +9,7 @@ import { CompositExporter } from "../exporter/exporter"
 import { LastRunStore } from "../last_run_store"
 import { GithubRepositoryClient } from "../client/github_repository_client"
 import { CustomReportCollection, createCustomReportCollection, aggregateCustomReportArtifacts } from "../custom_report_collection"
+import { failure, Result, success } from "../result"
 
 export class CircleciRunner implements Runner {
   service: string = 'circleci'
@@ -36,8 +37,9 @@ export class CircleciRunner implements Runner {
     }
   }
 
-  async run () {
-    if (!this.config) return
+  async run (): Promise<Result<void, Error>> {
+    let result: Result<void, Error> = success()
+    if (!this.config) return failure(new Error('this.config must not be undefined'))
     this.store = await LastRunStore.init(this.service, this.configDir, this.config.lastRunStore)
 
     let workflowReports: WorkflowReport[] = []
@@ -98,8 +100,10 @@ export class CircleciRunner implements Runner {
         testReports = testReports.concat(repoTestReports)
       }
       catch (error) {
-        console.error(`Some error raised in '${repo.fullname}', so it skipped.`)
+        const errorMessage = `Some error raised in '${repo.fullname}', so it skipped.`
+        console.error(errorMessage)
         console.error(error)
+        result = failure(new Error(errorMessage))
         continue
       }
     }
@@ -111,6 +115,8 @@ export class CircleciRunner implements Runner {
     await exporter.exportCustomReports(customReportCollection)
 
     this.store.save()
-    console.info(`Success: done execute '${this.service}'`)
+    console.info(`Done execute '${this.service}'. status: ${result.type}`)
+
+    return result
   }
 }

src/runner/github_runner.ts

@@ -9,6 +9,7 @@ import { CompositExporter } from "../exporter/exporter"
 import { LastRunStore } from "../last_run_store"
 import { GithubRepositoryClient } from "../client/github_repository_client"
 import { CustomReportCollection, createCustomReportCollection } from "../custom_report_collection"
+import { failure, Result, success } from "../result"
 
 export class GithubRunner implements Runner {
   service: string = 'github'
@@ -34,8 +35,9 @@ export class GithubRunner implements Runner {
     }
   }
 
-  async run () {
-    if (!this.config) return
+  async run (): Promise<Result<void, Error>> {
+    let result: Result<void, Error> = success()
+    if (!this.config) return failure(new Error('this.config must not be undefined'))
     this.store = await LastRunStore.init(this.service, this.configDir, this.config.lastRunStore)
 
     let workflowReports: WorkflowReport[] = []
@@ -69,8 +71,10 @@ export class GithubRunner implements Runner {
         }
       }
       catch (error) {
-        console.error(`Some error raised in '${repo.fullname}', so it skipped.`)
+        const errorMessage = `Some error raised in '${repo.fullname}', so it skipped.`
+        console.error(errorMessage)
         console.error(error)
+        result = failure(new Error(errorMessage))
         continue
       }
       this.setRepoLastRun(repo.fullname, repoWorkflowReports)
@@ -85,6 +89,8 @@ export class GithubRunner implements Runner {
     await exporter.exportCustomReports(customReportCollection)
 
     this.store.save()
-    console.info(`Success: done execute '${this.service}'`)
+    console.info(`Done execute '${this.service}'. status: ${result.type}`)
+
+    return result
   }
 }

src/runner/jenkins_runner.ts

@@ -8,6 +8,7 @@ import { JenkinsAnalyzer } from "../analyzer/jenkins_analyzer"
 import { JenkinsConfig, parseConfig } from "../config/jenkins_config"
 import { LastRunStore } from "../last_run_store"
 import { CustomReportCollection, createCustomReportCollection } from "../custom_report_collection"
+import { failure, Result, success } from "../result"
 
 export class JenkinsRunner implements Runner {
   service: string = 'jenkins'
@@ -34,9 +35,10 @@ export class JenkinsRunner implements Runner {
     }
   }
 
-  async run () {
-    if (!this.config) return
-    if (!this.client) return
+  async run (): Promise<Result<void, Error>> {
+    let result: Result<void, Error> = success()
+    if (!this.config) return failure(new Error('this.config must not be undefined'))
+    if (!this.client) return failure(new Error('this.client must not be undefined'))
     this.store = await LastRunStore.init(this.service, this.configDir, this.config.lastRunStore)
 
     const allJobs = await this.client.fetchJobs()
@@ -77,8 +79,10 @@ export class JenkinsRunner implements Runner {
         testReports = testReports.concat(jobTestReports)
       }
       catch (error) {
-        console.error(`Some error raised in '${configJob.name}', so it skipped.`)
+        const errorMessage = `Some error raised in '${configJob.name}', so it skipped.`
+        console.error(errorMessage)
         console.error(error)
+        result = failure(new Error(errorMessage))
         continue
       }
     }
@@ -90,6 +94,8 @@ export class JenkinsRunner implements Runner {
     await exporter.exportCustomReports(customReportCollection)
 
     this.store.save()
-    console.info(`Success: done execute '${this.service}'`)
+    console.info(`Done execute '${this.service}'. status: ${result.type}`)
+
+    return result
   }
 }

src/runner/runner.ts

@@ -2,9 +2,10 @@ import { YamlConfig } from "../config/config";
 import { GithubRunner } from "./github_runner";
 import { CircleciRunner } from "./circleci_runner";
 import { JenkinsRunner } from "./jenkins_runner";
+import { failure, Result, success } from "../result";
 
 export interface Runner {
-  run (): Promise<void>
+  run (): Promise<Result<void, Error>>
 }
 
 export class CompositRunner implements Runner {
@@ -24,9 +25,17 @@ export class CompositRunner implements Runner {
     }).filter((runner): runner is NonNullable<typeof runner> => runner !== undefined)
   }
 
-  async run () {
-    await Promise.all(
+  async run(): Promise<Result<void, Error>> {
+    const results = await Promise.all(
       this.runners.map((runner) => runner.run())
     )
+
+    const errorResults = results.filter(result => result.isFailure())
+    if (errorResults.length > 0) {
+      console.log('End with failure')
+      return failure(new Error('Some runner throws error'))
+    }
+
+    return success()
   }
 }