-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freezes julia session under a variety of circumstances #40
Comments
@Keno Any solutions about this issue. |
I've seen this too. I think it's an ITerm issue. Let me investigate. |
Keno
added a commit
to JuliaLang/julia
that referenced
this issue
Nov 21, 2018
The REPL beeping (blinking) code made the assumption that the prompt prefix is always a String. That's not necessarily the case, and in fact it can be an arbitrary funcion to be called when the prompt is printed (e.g. TerminalExtensions uses this for the iTerm integration). However, even worse, this code acquired a lock that it never released on error, causing a deadlock. Fix the original assumption and also add a try/catch/finally block such that future errors print the error rather than deadlocking the terminal. Fixes Keno/TerminalExtensions.jl#40
Thank you very much!
On Wed, Nov 21, 2018 at 10:08 Keno Fischer ***@***.***> wrote:
I've seen this too. I think it's an ITerm issue. Let me investigate.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFXxeKMz203fjRRfqKXxsc_7AFdrJUs9ks5uxYiEgaJpZM4Xcuom>
.
--
-monty
|
Turned out to be a Julia issue. See linked PR. |
Excellent. This is a “lifesaver “.
On Wed, Nov 21, 2018 at 11:23 Keno Fischer ***@***.***> wrote:
Turned out to be a Julia issue. See linked PR.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFXxeBh6pyQAZbD4LvJFQwGKUtiKa-WSks5uxZopgaJpZM4Xcuom>
.
--
-monty
|
Keno
added a commit
to JuliaLang/julia
that referenced
this issue
Nov 22, 2018
The REPL beeping (blinking) code made the assumption that the prompt prefix is always a String. That's not necessarily the case, and in fact it can be an arbitrary funcion to be called when the prompt is printed (e.g. TerminalExtensions uses this for the iTerm integration). However, even worse, this code acquired a lock that it never released on error, causing a deadlock. Fix the original assumption and also add a try/catch/finally block such that future errors print the error rather than deadlocking the terminal. Fixes Keno/TerminalExtensions.jl#40
KristofferC
pushed a commit
to JuliaLang/julia
that referenced
this issue
Nov 28, 2018
The REPL beeping (blinking) code made the assumption that the prompt prefix is always a String. That's not necessarily the case, and in fact it can be an arbitrary funcion to be called when the prompt is printed (e.g. TerminalExtensions uses this for the iTerm integration). However, even worse, this code acquired a lock that it never released on error, causing a deadlock. Fix the original assumption and also add a try/catch/finally block such that future errors print the error rather than deadlocking the terminal. Fixes Keno/TerminalExtensions.jl#40 (cherry picked from commit 038d866)
KristofferC
pushed a commit
to JuliaLang/julia
that referenced
this issue
Dec 12, 2018
The REPL beeping (blinking) code made the assumption that the prompt prefix is always a String. That's not necessarily the case, and in fact it can be an arbitrary funcion to be called when the prompt is printed (e.g. TerminalExtensions uses this for the iTerm integration). However, even worse, this code acquired a lock that it never released on error, causing a deadlock. Fix the original assumption and also add a try/catch/finally block such that future errors print the error rather than deadlocking the terminal. Fixes Keno/TerminalExtensions.jl#40 (cherry picked from commit 038d866)
KristofferC
pushed a commit
to JuliaLang/julia
that referenced
this issue
Feb 11, 2019
The REPL beeping (blinking) code made the assumption that the prompt prefix is always a String. That's not necessarily the case, and in fact it can be an arbitrary funcion to be called when the prompt is printed (e.g. TerminalExtensions uses this for the iTerm integration). However, even worse, this code acquired a lock that it never released on error, causing a deadlock. Fix the original assumption and also add a try/catch/finally block such that future errors print the error rather than deadlocking the terminal. Fixes Keno/TerminalExtensions.jl#40 (cherry picked from commit 038d866)
KristofferC
pushed a commit
to JuliaLang/julia
that referenced
this issue
Feb 20, 2020
The REPL beeping (blinking) code made the assumption that the prompt prefix is always a String. That's not necessarily the case, and in fact it can be an arbitrary funcion to be called when the prompt is printed (e.g. TerminalExtensions uses this for the iTerm integration). However, even worse, this code acquired a lock that it never released on error, causing a deadlock. Fix the original assumption and also add a try/catch/finally block such that future errors print the error rather than deadlocking the terminal. Fixes Keno/TerminalExtensions.jl#40 (cherry picked from commit 038d866)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have had some problems with TerminalExtensions freezing my julia session so that I can't type anything and things like Ctrl-C have no effect. It seems to occur in a variety of situations. I am using TerminalExtensions 0.4.0, iTerm2 3.2.3 and have reproduced it with julia 0.7.0 and 1.0.1. Here is a simple example that reproduces it on my machine from the start of a fresh julia session:
using TerminalExtensions
and hit returna
a
I have also run into similar freezes when using tab completion, but haven't been able to come up with a reproducible example of this. Maybe the issues are related?
The text was updated successfully, but these errors were encountered: