chore: refactor healthcheck package to improve code readability and maintainability

Author: Keloran

healthcheck.go

@@ -1,160 +1,160 @@
 package healthcheck
 
 import (
-  "encoding/json"
-  "fmt"
-  "io/ioutil"
-  "net/http"
-  "os"
-  "strings"
-
-  "github.com/go-ping/ping"
+	"encoding/json"
+	"fmt"
+	"io/ioutil"
+	"net/http"
+	"os"
+	"strings"
+
+	"github.com/go-ping/ping"
 )
 
 // HTTP the request as done by routing
 func HTTP(w http.ResponseWriter, r *http.Request) {
-  hc := HealthCheck{
-    Name:         os.Getenv("SERVICE_NAME"),
-    URL:          r.Host,
-    Dependencies: os.Getenv("SERVICE_DEPENDENCIES"),
-  }
-
-  health, err := hc.Check()
-  if err != nil {
-    w.Header().Set("Content-Type", "application/health+json")
-    j, _ := json.Marshal(Health{
-      Status: HealthFail,
-    })
-    w.WriteHeader(http.StatusOK)
-    _, fErr := w.Write(j)
-    if fErr != nil {
-      fmt.Printf("write response: %v\n", fErr)
-    }
-    fmt.Printf("http health failed: %+v\n", err)
-    return
-  }
-
-  j, _ := json.Marshal(health)
-  w.Header().Set("Content-Type", "application/health+json")
-  _, fErr := w.Write(j)
-  if fErr != nil {
-    fmt.Printf("write response: %v\n", fErr)
-  }
+	hc := HealthCheck{
+		Name:         os.Getenv("SERVICE_NAME"),
+		URL:          r.Host,
+		Dependencies: os.Getenv("SERVICE_DEPENDENCIES"),
+	}
+
+	health, err := hc.Check()
+	if err != nil {
+		w.Header().Set("Content-Type", "application/health+json")
+		j, _ := json.Marshal(Health{
+			Status: HealthFail,
+		})
+		w.WriteHeader(http.StatusOK)
+		_, fErr := w.Write(j)
+		if fErr != nil {
+			fmt.Printf("write response: %v\n", fErr)
+		}
+		fmt.Printf("http health failed: %+v\n", err)
+		return
+	}
+
+	j, _ := json.Marshal(health)
+	w.Header().Set("Content-Type", "application/health+json")
+	_, fErr := w.Write(j)
+	if fErr != nil {
+		fmt.Printf("write response: %v\n", fErr)
+	}
 }
 
 // Check do the health check itself
 func (h HealthCheck) Check() (Health, error) {
-  health := Health{
-    Name:         h.Name,
-    URL:          h.URL,
-    Status:       HealthFail,
-    Dependencies: nil,
-  }
-
-  health.Status = HealthPass
-  if h.Dependencies != "" {
-    deps, err := h.getDependencies()
-    if err != nil {
-      return health, err
-    }
-
-    checkedDeps := []Health{}
-    for _, dep := range deps.Dependencies {
-      d, err := dep.check()
-      if err != nil {
-        return health, err
-      }
-      checkedDeps = append(checkedDeps, d)
-    }
-
-    health.Dependencies = checkedDeps
-  }
-
-  // now set to failed if a dependency failed
-  for _, dep := range health.Dependencies {
-    if dep.Status == HealthFail {
-      health.Status = HealthFail
-    }
-  }
-
-  return health, nil
+	health := Health{
+		Name:         h.Name,
+		URL:          h.URL,
+		Status:       HealthFail,
+		Dependencies: nil,
+	}
+
+	health.Status = HealthPass
+	if h.Dependencies != "" {
+		deps, err := h.getDependencies()
+		if err != nil {
+			return health, err
+		}
+
+		checkedDeps := []Health{}
+		for _, dep := range deps.Dependencies {
+			d, err := dep.check()
+			if err != nil {
+				return health, err
+			}
+			checkedDeps = append(checkedDeps, d)
+		}
+
+		health.Dependencies = checkedDeps
+	}
+
+	// now set to failed if a dependency failed
+	for _, dep := range health.Dependencies {
+		if dep.Status == HealthFail {
+			health.Status = HealthFail
+		}
+	}
+
+	return health, nil
 }
 
 // getDependencies get the list of dependencies
 func (h HealthCheck) getDependencies() (Dependencies, error) {
-  deps := Dependencies{}
-  err := json.Unmarshal([]byte(h.Dependencies), &deps)
-  if err != nil {
-    return deps, err
-  }
+	deps := Dependencies{}
+	err := json.Unmarshal([]byte(h.Dependencies), &deps)
+	if err != nil {
+		return deps, err
+	}
 
-  return deps, nil
+	return deps, nil
 }
 
 // check the dependency status
 func (d Dependency) check() (Health, error) {
-  if strings.Contains(d.URL, "$") {
-    d.URL = os.Getenv(d.URL[1:])
-  }
+	if strings.Contains(d.URL, "$") {
+		d.URL = os.Getenv(d.URL[1:])
+	}
 
-  // Ping check
-  if d.Ping {
-    return d.ping()
-  }
+	// Ping check
+	if d.Ping {
+		return d.ping()
+	}
 
-  // Standard check
-  return d.curl()
+	// Standard check
+	return d.curl()
 }
 
 // ping checks
 func (d Dependency) ping() (Health, error) {
-  h := Health{
-    Name:   d.Name,
-    URL:    d.URL,
-    Status: HealthFail,
-  }
-
-  pinger, err := ping.NewPinger(h.URL)
-  if err != nil {
-    return h, err
-  }
-
-  pinger.Count = 3
-  if err := pinger.Run(); err != nil {
-    return h, err
-  }
-
-  h.Status = HealthPass
-  return h, nil
+	h := Health{
+		Name:   d.Name,
+		URL:    d.URL,
+		Status: HealthFail,
+	}
+
+	pinger, err := ping.NewPinger(h.URL)
+	if err != nil {
+		return h, err
+	}
+
+	pinger.Count = 3
+	if err := pinger.Run(); err != nil {
+		return h, err
+	}
+
+	h.Status = HealthPass
+	return h, nil
 }
 
 // curl checks
 func (d Dependency) curl() (Health, error) {
-  h := Health{}
-  p, err := http.Get(d.URL)
-  if err != nil {
-    h = Health{
-      URL:    d.URL,
-      Status: HealthFail,
-    }
-    return h, err
-  }
-
-  defer func() {
-    _ = p.Body.Close()
-  }()
-
-  b, err := ioutil.ReadAll(p.Body)
-  if err != nil {
-    h = Health{
-      URL:    d.URL,
-      Status: HealthFail,
-    }
-    return h, err
-  }
-  jerr := json.Unmarshal(b, &h)
-  if jerr != nil {
-    return h, jerr
-  }
-  return h, nil
+	h := Health{}
+	p, err := http.Get(d.URL)
+	if err != nil {
+		h = Health{
+			URL:    d.URL,
+			Status: HealthFail,
+		}
+		return h, err
+	}
+
+	defer func() {
+		_ = p.Body.Close()
+	}()
+
+	b, err := ioutil.ReadAll(p.Body)
+	if err != nil {
+		h = Health{
+			URL:    d.URL,
+			Status: HealthFail,
+		}
+		return h, err
+	}
+	jerr := json.Unmarshal(b, &h)
+	if jerr != nil {
+		return h, jerr
+	}
+	return h, nil
 }