Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate @swc/core from dependencies to devDependencies #48

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

radist2s
Copy link
Contributor

@radist2s radist2s commented Apr 17, 2023

🛠 Refactor: Relocate @swc/core dependency

🔄 Changes

  • Remove @swc/core from dependencies
  • Add @swc/core to devDependencies and peerDependencies

🎯 Motivation

The refactoring allows users to independently install any version of @swc/core, providing more flexibility in managing dependency versions. This is especially helpful for fixing the version of @swc/core when working with unstable plugins, ensuring better compatibility and stability.

@changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2023

🦋 Changeset detected

Latest commit: 205cca9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
storybook-addon-swc Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@radist2s radist2s closed this Apr 17, 2023
@radist2s radist2s reopened this Apr 17, 2023
Copy link
Owner

@Karibash Karibash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Karibash Karibash merged commit 7c585e7 into Karibash:main Apr 18, 2023
@github-actions github-actions bot mentioned this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants