From 3bd8c6b46fb6f7d5eaa0c670950bdd3a8eb5aad2 Mon Sep 17 00:00:00 2001
From: Saurabh Kumar Bajpai <saurabhkumarbajpaiai@gmail.com>
Date: Sun, 2 Aug 2026 15:55:02 +0530
Subject: [PATCH] fix: code quality and safety improvements

---
 examples/calculator/src/index.tsx | 4 ++--
 packages/ui/src/NumberInput.ts    | 2 +-
 packages/ui/src/Pagination.ts     | 2 +-
 packages/ui/src/prompts.ts        | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/examples/calculator/src/index.tsx b/examples/calculator/src/index.tsx
index 852911990..8783787e9 100644
--- a/examples/calculator/src/index.tsx
+++ b/examples/calculator/src/index.tsx
@@ -85,7 +85,7 @@ function safeEval(expr: string): string {
     if (tokens.length === 0) return '0';
 
     // Handle initial negative number
-    if (tokens[0] === '-' && tokens.length > 1 && !isNaN(Number(tokens[1]))) {
+    if (tokens[0] === '-' && tokens.length > 1 && !Number.isNaN(Number(tokens[1]))) {
         tokens.splice(0, 2, '-' + tokens[1]);
     }
 
@@ -146,7 +146,7 @@ function safeEval(expr: string): string {
         j += 2;
     }
 
-    if (isNaN(res) || !isFinite(res)) return 'Error';
+    if (Number.isNaN(res) || !isFinite(res)) return 'Error';
 
     const resStr = String(res);
     if (resStr.includes('.') && resStr.split('.')[1].length > 8) {
diff --git a/packages/ui/src/NumberInput.ts b/packages/ui/src/NumberInput.ts
index d664d2124..a1e4eca74 100644
--- a/packages/ui/src/NumberInput.ts
+++ b/packages/ui/src/NumberInput.ts
@@ -68,7 +68,7 @@ export class NumberInput extends Widget {
     get numericValue(): number | null {
         if (this._raw === '' || this._raw === '-') return null;
         const n = parseFloat(this._raw);
-        return isNaN(n) ? null : this._clamp(n);
+        return Number.isNaN(n) ? null : this._clamp(n);
     }
 
     /** Raw text string (what the user typed). */
diff --git a/packages/ui/src/Pagination.ts b/packages/ui/src/Pagination.ts
index 3cb386180..5900ac71f 100644
--- a/packages/ui/src/Pagination.ts
+++ b/packages/ui/src/Pagination.ts
@@ -27,7 +27,7 @@ export class Pagination extends Widget {
     }
 
     private _clamp(n: number): number {
-        if (isNaN(n) || !isFinite(n)) return 1;
+        if (Number.isNaN(n) || !isFinite(n)) return 1;
         return Math.min(this._totalPages, Math.max(1, n));
     }
 
diff --git a/packages/ui/src/prompts.ts b/packages/ui/src/prompts.ts
index b92bb28ba..b248a6ac4 100644
--- a/packages/ui/src/prompts.ts
+++ b/packages/ui/src/prompts.ts
@@ -113,7 +113,7 @@ async function promptSelect<T = string>(options: SelectPromptOptions<T>): Promis
                     return;
                 }
                 const n = parseInt(trimmed, 10);
-                if (!isNaN(n) && n >= 1 && n <= choices.length) {
+                if (!Number.isNaN(n) && n >= 1 && n <= choices.length) {
                     rl.close();
                     resolve(choices[n - 1].value);
                     return;