Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Deleting the source code thows an exception #1963

Open
lordrip opened this issue Jun 13, 2023 · 4 comments
Open

Deleting the source code thows an exception #1963

lordrip opened this issue Jun 13, 2023 · 4 comments
Labels
bug Something isn't working code editor Relates to the code editor good first issue Good for newcomers

Comments

@lordrip
Copy link
Collaborator

lordrip commented Jun 13, 2023

Describe the Bug

An unhandled exception is thrown upon deleting the source code

Steps to Reproduce the Bug or Issue

  1. Starting with a blank canvas.
  2. Delete all the source code.
  3. See the exception thrown.

Screenshots or Videos

Screencast.from.2023-06-13.16-09-37.webm

Platform

  • OS: [Linux]
  • Browser: [Firefox]
  • Version: [1.0.0]
@lordrip lordrip added bug Something isn't working good first issue Good for newcomers code editor Relates to the code editor labels Jun 13, 2023
@tplevko tplevko self-assigned this Jun 27, 2023
@tplevko
Copy link
Contributor

tplevko commented Jun 29, 2023

Investigating this issue let me to figuring, that the error was there for quite a long time, but was visible only in the console. Only after this commit - upgrading the webpack-dev-server, which introduced this fix - overlay displays unhandled promise rejection started the error appear in the overlay.

That being said, there seems to be an issue with the version of monaco-editor in the package.json. The issue seems to be occurring since the upgrade to version 0.35.0 - prior to this version there was no such error.

The question now is, whether we want to downgrade the monaco-editor to version 0.34.1, or should I try to find another solution.

@lordrip
Copy link
Collaborator Author

lordrip commented Jun 29, 2023

I think that it will be better to leave the version downgrade as a last-resort solution since in production mode, there's a console error only.

@lordrip
Copy link
Collaborator Author

lordrip commented Jun 30, 2023

Just for testing purposes, I downgraded monaco-editor to 0.34.1 and I don't see the error message in Firefox 🤔

@tplevko
Copy link
Contributor

tplevko commented Jun 30, 2023

I know - going through the changelog from monaco-editor 0.35.0, I can't figure out, what might have introduced this error.

@tplevko tplevko removed their assignment Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working code editor Relates to the code editor good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants