Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roblox_incorrect_color3_new_bounds does not check for values < 0 #83

Closed
sayhisam1 opened this issue Jan 25, 2020 · 0 comments · Fixed by #319
Closed

roblox_incorrect_color3_new_bounds does not check for values < 0 #83

sayhisam1 opened this issue Jan 25, 2020 · 0 comments · Fixed by #319
Labels
A-lints Area: Relating to a lint directly A-roblox Area: Roblox specific C-enhancement Category: Feature request or improvement E-easy Call for participation: Experience needed to fix: Easy / not much

Comments

@sayhisam1
Copy link

sayhisam1 commented Jan 25, 2020 •
edited
Loading

While values < 0 are not supported for Roblox's Color3.new() function (and is also specified in the linter's error message), this should really be enforced just for consistency.

Example: Color3.new(-1,0,0)
@sayhisam1 sayhisam1 changed the title roblox_incorrect_color3_new_bounds Does not check for values < 0 roblox_incorrect_color3_new_bounds does not check for values < 0 Jan 25, 2020
@Kampfkarren Kampfkarren added A-lints Area: Relating to a lint directly A-roblox Area: Roblox specific C-bug Category: Bug labels Jan 25, 2020
@Kampfkarren Kampfkarren added C-enhancement Category: Feature request or improvement E-easy Call for participation: Experience needed to fix: Easy / not much and removed C-bug Category: Bug labels Oct 3, 2020
@Kampfkarren Kampfkarren mentioned this issue Oct 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lints Area: Relating to a lint directly A-roblox Area: Roblox specific C-enhancement Category: Feature request or improvement E-easy Call for participation: Experience needed to fix: Easy / not much
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check negative numbers in Color3 bounds Kampfkarren/selene
2 participants
@Kampfkarren @sayhisam1