-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify envs to be compatible with twrl #8
Closed
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
70eb229
Modified specs to follow gym API
a56188c
Update function names
1fe33fa
Experiment uses new specs
522b8a4
Changed function calls to getters
9e92921
table with all rlenv envs
1c276f2
Update function calls, added new steps method, updated README
63cf6db
Added timestep limits, exposed start function added _start function t…
c20c8b8
Added render
a9ea21e
Added zoom option
430a2b4
Added zoom variable to experiment
358a8c7
fixed variable name
135bf69
Modified specs to follow gym API
2afdffe
Update function names
0e3b561
Experiment uses new specs
3a39f0c
Changed function calls to getters
834c837
table with all rlenv envs
b6f086b
Update function calls, added new steps method, updated README
2319531
Added timestep limits, exposed start function added _start function t…
b02b760
Added render
68f773e
Added zoom option
0f86433
Added zoom variable to experiment
904f747
fixed variable name
922f10d
Merge remote-tracking branch 'origin/twrl' into twrl
c1f3b16
Modified XOWorld to new api standards
9114305
1 channel for XOWorld
796bc58
Added super call
eb8ea9b
Merge branch 'master' into twrl
52ad76d
Added base tests
1096f31
Merge remote-tracking branch 'origin/master' into twrl
59da7cd
Modified Minecraft functions to support api
2d23ed7
Exclude minecraft from tests
55f90eb
Added assertions to tests
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zoom
should be part ofopts
and handled byEnv
- 10 was hard-coded for Catch, but the default of 1 is appropriate for Atari.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall I set the default to 10 for Catch or leave this exposed for the user as well?