Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overwritting action by environment #56

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Master.lua
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ function Master:train()
-- Catch CTRL-C to save
self:catchSigInt()

local reward, state, terminal = 0, self.env:start(), false
local reward, state, terminal, actionTaken = 0, self.env:start(), false, false

-- Set environment and agent to training mode
self.env:training()
Expand All @@ -97,7 +97,12 @@ function Master:train()
local action = self.agent:observe(reward, state, terminal) -- As results received, learn in training mode
if not terminal then
-- Act on environment (to cause transition)
reward, state, terminal = self.env:step(action)
reward, state, terminal, actionTaken = self.env:step(action)
-- Update experience memory with actual action
if actionTaken and actionTaken ~= action then
action = actionTaken
self.agent.memory.actions[self.agent.memory.index] = action
end
-- Track score
episodeScore = episodeScore + reward
else
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ You can use a custom environment (as the path to a Lua file/`rlenvs`-namespaced

If the environment has separate behaviour during training and testing it should also implement `training` and `evaluate` methods - otherwise these will be added as empty methods during runtime. The environment can also implement a `getDisplay` method (with a mandatory `getDisplaySpec` method for determining screen size) which will be used for displaying the screen/computing saliency maps, where `getDisplay` must return a RGB (3D) tensor; this can also be utilised even if the state is not an image (although saliency can only be computed for states that are images). This **must** be implemented to have a visual display/computing saliency maps. The `-zoom` factor can be used to increase the size of small displays.

Custom environments can also control the action selection process, specifying the actual action taken when it differs from that selected by the network. This allows the agent to learn from hand-crafted behaviours, human experts or pre-planned sequences. To achieve this environments can optionally return `actionTaken` from the `step` method. i.e. `return reward, state, terminal[, actionTaken]`.

You can also use a custom model (body) with `-modelBody`, which replaces the usual DQN convolutional layers with a custom Torch neural network (as the path to a Lua file/`models`-namespaced environment). The class must include a `createBody` method which returns the custom neural network. The model will receive a stack of the previous states (as determined by `-histLen`), and must reshape them manually if needed. The DQN "heads" will then be constructed as normal, with `-hiddenSize` used to change the size of the fully connected layer if needed.

For an example on a GridWorld environment, run `./run.sh demo-grid` - the demo also works with `qlua` and experience replay agents. The custom environment and network can be found in the [examples](https://github.com/Kaixhin/Atari/tree/master/examples) folder.
Expand Down
10 changes: 7 additions & 3 deletions async/A3CAgent.lua
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ function A3CAgent:learn(steps, from)
log.info('A3CAgent starting | steps=%d', steps)
local reward, terminal, state = self:start()

local actionTaken

self.states:resize(self.batchSize, table.unpack(state:size():totable()))

self.tic = torch.tic()
Expand All @@ -53,9 +55,11 @@ function A3CAgent:learn(steps, from)
local V, probability = table.unpack(self.policyNet_:forward(state))
local action = torch.multinomial(probability, 1):squeeze()

reward, terminal, state, actionTaken = self:takeAction(action)
if actionTaken and actionTaken ~= action then
action = actionTaken
end
self.actions[self.batchIdx] = action

reward, terminal, state = self:takeAction(action)
self.rewards[self.batchIdx] = reward

self:progress(steps)
Expand Down Expand Up @@ -98,7 +102,7 @@ function A3CAgent:accumulateGradients(terminal, state)
local gradEntropy = torch.log(probability) + 1
-- Add to target to improve exploration (prevent convergence to suboptimal deterministic policy)
self.policyTarget:add(self.beta, gradEntropy)

self.policyNet_:backward(self.states[i], self.targets)
end
end
Expand Down
7 changes: 5 additions & 2 deletions async/AsyncAgent.lua
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,10 @@ end


function AsyncAgent:takeAction(action)
local reward, rawObservation, terminal = self.env:step(action - self.actionOffset)
local reward, rawObservation, terminal, actionTaken = self.env:step(action - self.actionOffset)
if actionTaken then
actionTaken = actionTaken + self.actionOffset
end
if self.rewardClip > 0 then
reward = math.max(reward, -self.rewardClip)
reward = math.min(reward, self.rewardClip)
Expand All @@ -91,7 +94,7 @@ function AsyncAgent:takeAction(action)
self.stateBuffer:push(observation)
end

return reward, terminal, self.stateBuffer:readAll()
return reward, terminal, self.stateBuffer:readAll(), actionTaken
Copy link
Contributor Author

@mryellow mryellow Sep 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add the offset actionOffset before returning so it doesn't need adding to compare actionTaken ~= action.

edit: Done

end


Expand Down
9 changes: 7 additions & 2 deletions async/NStepQAgent.lua
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ function NStepQAgent:learn(steps, from)
log.info('NStepQAgent starting | steps=%d | ε=%.2f -> %.2f', steps, self.epsilon, self.epsilonEnd)
local reward, terminal, state = self:start()

local actionTaken

self.states:resize(self.batchSize, table.unpack(state:size():totable()))
self.tic = torch.tic()
repeat
Expand All @@ -42,9 +44,12 @@ function NStepQAgent:learn(steps, from)
self.states[self.batchIdx]:copy(state)

local action = self:eGreedy(state, self.policyNet_)
self.actions[self.batchIdx] = action

reward, terminal, state = self:takeAction(action)
reward, terminal, state, actionTaken = self:takeAction(action)
if actionTaken and actionTaken ~= action then
action = actionTaken
end
self.actions[self.batchIdx] = action
self.rewards[self.batchIdx] = reward

self:progress(steps)
Expand Down
7 changes: 5 additions & 2 deletions async/OneStepQAgent.lua
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,16 @@ function OneStepQAgent:learn(steps, from)
log.info('%s starting | steps=%d | ε=%.2f -> %.2f', self.agentName, steps, self.epsilon, self.epsilonEnd)
local reward, terminal, state = self:start()

local action, state_
local action, state_, actionTaken

self.tic = torch.tic()
for step1=1,steps do
if not terminal then
action = self:eGreedy(state, self.policyNet)
reward, terminal, state_ = self:takeAction(action)
reward, terminal, state_, actionTaken = self:takeAction(action)
if actionTaken and actionTaken ~= action then
action = actionTaken
end
else
reward, terminal, state_ = self:start()
end
Expand Down