Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish prioritised experience replay #42

Open
Kaixhin opened this issue Jun 16, 2016 · 2 comments
Open

Finish prioritised experience replay #42

Kaixhin opened this issue Jun 16, 2016 · 2 comments

Comments

@Kaixhin
Copy link
Owner

Kaixhin commented Jun 16, 2016

Rank-based prioritised experience replay appears to be working, but technically needs some changes. Instead of storing terminal states with a priority of 0, they should not be stored at all. This requires more checks, as the elements in the experience replay memory and the elements in the priority queue will differ.

Secondly, proportional prioritised experience replay still needs to be implemented. See here and here for an implementation of the sum binary tree.

For reference, below are results from a working implementation of rank-based PER on Frostbite:
scores

@Damcy
Copy link

Damcy commented Jul 25, 2016

maybe we can store experience as a tuple like (s_t, a, r, s_t_1, t), terminal state will not be store in experience replay if use this pattern. usually t is 0, and t == 1 would generate tuple (s, a, r, TERMINAL_STATE, 1)

@Kaixhin
Copy link
Owner Author

Kaixhin commented Aug 16, 2016

Note: It might be worth subclassing the Heap from torchlib for the priority queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants