Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1281 numba mvc support #1282

Merged
merged 2 commits into from
Aug 14, 2023
Merged

#1281 numba mvc support #1282

merged 2 commits into from
Aug 14, 2023

Conversation

djherbis
Copy link
Contributor

@djherbis djherbis commented Aug 9, 2023

No description provided.

@djherbis
Copy link
Contributor Author

This is blocked on fixes from #1288 so I'll merge this and see if it works.

@djherbis djherbis merged commit 8e15dd3 into main Aug 14, 2023
3 checks passed
@djherbis djherbis deleted the numba-mvc branch August 14, 2023 13:41
@@ -261,6 +261,10 @@ RUN pip install scipy \
apt-get install -y pandoc && \
pip install essentia

# #1281 Install numba MVC support:
Copy link
Contributor

@rosbo rosbo Aug 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djherbis Do you have a bug for adding numba MVC support with where you found the instructions? Why it was necessary? etc.

Tests are failing with:

  File "/opt/conda/lib/python3.10/site-packages/numba/cuda/codegen.py", line 159, in get_cubin
    linker.add_ptx(ptx.encode())
  File "/opt/conda/lib/python3.10/site-packages/numba/cuda/cudadrv/driver.py", line 2710, in add_ptx
    compile_result = compile_ptx(ptx.decode(), self.ptx_compile_options)
  File "/opt/conda/lib/python3.10/site-packages/ptxcompiler/api.py", line 33, in compile_ptx
    raise RuntimeError(error_log)
RuntimeError: ptxas application ptx input, line 9; fatal   : Unsupported .version 8.0; current version is '7.8'

Which seems to indicate an incompatible version of ptx.

Also, this is installing cuda (gpu) specific libraries and should be inside a {{ if eq .Accelerator "gpu" }} ... {{ end }} block.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this guide which is probably where you got the instructions from: https://numba.readthedocs.io/en/stable/cuda/minor_version_compatibility.html#enabling-mvc-support

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rosbo #1281 was the issue, numba was installing before but not actually working for some users.

Fixed so its only in the GPU image:
c195472

Note that the image was broken before these changes too, we were getting numba failures from @psbang PR, so I merged mine hoping it would fix theirs (it did change the error).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants