update

Author: Kachit

auth.go

@@ -5,15 +5,18 @@ import (
 	"time"
 )
 
+//Authentication token
 type AuthToken struct {
 	Token     string
 	ExpiresAt int64
 }
 
+//Check token is valid
 func (t *AuthToken) IsValid() bool {
 	return t.IsNotExpired() && t.Token != ""
 }
 
+//Check token is not expired
 func (t *AuthToken) IsNotExpired() bool {
 	ts := time.Now().Unix()
 	return t.ExpiresAt > ts

sales.go

@@ -1,10 +1,16 @@
 package appstore_sdk
 
+import "fmt"
+
 type SalesReportsResource struct {
 	*ResourceAbstract
 }
 
 func (srr *SalesReportsResource) GetReport(filter *SalesReportsFilter) (*Response, error) {
 	filter.VendorNumber = srr.config.VendorNo
+	err := filter.IsValid()
+	if err != nil {
+		return nil, fmt.Errorf("SalesReportsResource@GetReport invalid filter: %v", err)
+	}
 	return srr.get("v1/salesReports", filter.ToQueryParamsMap())
 }

sales_filters.go

@@ -155,8 +155,5 @@ func (f *SalesReportsFilter) IsValid() error {
 	if f.Frequency == "" {
 		return fmt.Errorf("SalesReportsFilter@IsValid: %v", "Frequency is required")
 	}
-	if f.VendorNumber == "" {
-		return fmt.Errorf("SalesReportsFilter@IsValid: %v", "VendorNumber is required")
-	}
 	return nil
 }

sales_filters_test.go

@@ -77,33 +77,23 @@ func Test_SalesReports_Filter_SetVersion(t *testing.T) {
 }
 
 func Test_SalesReports_Filter_IsValid(t *testing.T) {
-	filter := &SalesReportsFilter{VendorNumber: "foo"}
+	filter := &SalesReportsFilter{}
 	date, _ := time.Parse("2006-01-02", "2020-05-05")
 	filter.Daily().TypeSales().SubTypeSummary().Version10().SetReportDate(date)
 	err := filter.IsValid()
 	assert.Nil(t, err)
 }
 
 func Test_SalesReports_Filter_IsInValidReportDate(t *testing.T) {
-	filter := &SalesReportsFilter{VendorNumber: "foo"}
+	filter := &SalesReportsFilter{}
 	filter.Daily().TypeSales().SubTypeSummary().Version10()
-	filter.VendorNumber = ""
 	err := filter.IsValid()
 	assert.Error(t, err)
 	assert.Equal(t, "SalesReportsFilter@IsValid: ReportDate is required", err.Error())
 }
 
-func Test_SalesReports_Filter_IsInValidVendorNumber(t *testing.T) {
-	filter := &SalesReportsFilter{}
-	date, _ := time.Parse("2006-01-02", "2020-05-05")
-	filter.Daily().TypeSales().SubTypeSummary().Version10().SetReportDate(date)
-	err := filter.IsValid()
-	assert.Error(t, err)
-	assert.Equal(t, "SalesReportsFilter@IsValid: VendorNumber is required", err.Error())
-}
-
 func Test_SalesReports_Filter_IsInValidReportType(t *testing.T) {
-	filter := &SalesReportsFilter{VendorNumber: "foo"}
+	filter := &SalesReportsFilter{}
 	date, _ := time.Parse("2006-01-02", "2020-05-05")
 	filter.Daily().SubTypeSummary().Version10().SetReportDate(date)
 	err := filter.IsValid()
@@ -112,7 +102,7 @@ func Test_SalesReports_Filter_IsInValidReportType(t *testing.T) {
 }
 
 func Test_SalesReports_Filter_IsInValidReportSubType(t *testing.T) {
-	filter := &SalesReportsFilter{VendorNumber: "foo"}
+	filter := &SalesReportsFilter{}
 	date, _ := time.Parse("2006-01-02", "2020-05-05")
 	filter.Daily().TypeSales().Version10().SetReportDate(date)
 	err := filter.IsValid()
@@ -121,7 +111,7 @@ func Test_SalesReports_Filter_IsInValidReportSubType(t *testing.T) {
 }
 
 func Test_SalesReports_Filter_IsInValidFrequency(t *testing.T) {
-	filter := &SalesReportsFilter{VendorNumber: "foo"}
+	filter := &SalesReportsFilter{}
 	date, _ := time.Parse("2006-01-02", "2020-05-05")
 	filter.SubTypeSummary().TypeSales().Version10().SetReportDate(date)
 	err := filter.IsValid()

sales_test.go

@@ -0,0 +1,18 @@
+package appstore_sdk
+
+import (
+	"github.com/stretchr/testify/assert"
+	"testing"
+)
+
+func Test_Sales_GetReport_InvalidFilter(t *testing.T) {
+	config := buildStubConfig()
+	token := buildStubAuthToken()
+	transport := NewHttpTransport(config, token, nil)
+	resource := &SalesReportsResource{ResourceAbstract: newResourceAbstract(transport, config)}
+	filter := &SalesReportsFilter{}
+	filter.Daily().TypeSales().SubTypeSummary().Version10()
+	_, err := resource.GetReport(filter)
+	assert.Error(t, err)
+	assert.Equal(t, "SalesReportsResource@GetReport invalid filter: SalesReportsFilter@IsValid: ReportDate is required", err.Error())
+}